Skip to content

Conversation

@liu4480
Copy link

@liu4480 liu4480 commented Aug 8, 2016

In line 140 of booth.spec, there is "install -m 644 %{S:2}", but
when build booth on SLE12 or openSUSE Leap42.1, it reports %{SOURCE2}
is not defined. I guess the file should be contrib/geo-cluster.fwd.
This patch can fix the build error.

In line 140 of booth.spec, there is "install -m 644 %{S:2}", but
when build booth on SLE12 or openSUSE Leap42.1, it reports %{SOURCE2}
is not defined. I guess the file should be contrib/geo-cluster.fwd.
This patch can fix the build error.
@dmuhamedagic
Copy link

Why not then just add the source2? This code was there a year and a half ago, strange that it wasn't noticed earlier.

@liu4480
Copy link
Author

liu4480 commented Aug 26, 2016

@dmuhamedagic If we add source2, we need to put geo-cluster.fwd in the build directory same as the tarball, and geo-cluster.fwd is already in the tarball, I do not think it necessary to put geo-cluster.fwd in build the directory.

@dmuhamedagic
Copy link

On Thu, Aug 25, 2016 at 06:53:05PM -0700, Bin Liu wrote:

@dmuhamedagic If we add source2, we need to put geo-cluster.fwd in the build directory as the tarball, and geo-cluster.fwd is already in the source of booth, I do not think it necessary to put geo-cluster.fwd in the directory.

Yes, that's right. We can merge this. Thanks!

@liu4480
Copy link
Author

liu4480 commented Aug 26, 2016

Thanks

@dmuhamedagic dmuhamedagic merged commit da3bba2 into ClusterLabs:master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants