Merge cc_supports_flag implementation from pacemaker #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main change is: Check for compiler flags with -Werror For example for -fstack-protector, it is accepted by gcc for all targets, however those targets where it is actually not supported, it will print a warning like "-fstack-protector is not supported for this platform" which raises an error when using -Werror later. So better not add -fstack-protector then to the CC_EXTRA_FLAGS
Member
|
Pulled, thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is:
Check for compiler flags with -Werror
For example for -fstack-protector, it is accepted by gcc for
all targets, however those targets where it is actually not
supported, it will print a warning like
"-fstack-protector is not supported for this platform"
which raises an error when using -Werror later. So better
not add -fstack-protector then to the CC_EXTRA_FLAGS