Build: create and set working directory #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gao-yan
reviewed
May 24, 2017
src/main.c
Outdated
| if (chdir(BOOTH_CORE_DIR) < 0) { | ||
| log_error("cannot change working directory to %s", BOOTH_CORE_DIR); | ||
| } else { | ||
| log_info("booth working directory set to %s", BOOTH_CORE_DIR); |
Member
There was a problem hiding this comment.
I think we can drop this message, or the trace level should be sufficient ;-)
Author
There was a problem hiding this comment.
the message will be removed, as requested ;)
gao-yan
reviewed
May 24, 2017
booth.spec
Outdated
| %dir /usr/lib/ocf/lib/booth | ||
| %dir %{_sysconfdir}/booth | ||
| %dir %{_var}/lib/booth | ||
| %dir %{_var}/lib/booth/cores |
Member
There was a problem hiding this comment.
Would it make sense to add %attr defining the exact expected permissions like:
%dir %attr (750, %{uname}, %{gname}) %{_var}/lib/booth
%dir %attr (750, %{uname}, %{gname}) %{_var}/lib/booth/cores
?
Author
There was a problem hiding this comment.
sure, I will change this
Author
|
Hello @dmuhamedagic, did you have a chance to look at this pull request? Booth works quite unpredictable without these changes.. ? |
|
Yes, I did look at it and, since Yan had no further objections, we can merge it.
|
|
Thanks! |
Member
|
Thank you, Dejan and Chris! |
Author
|
Thank you as well! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, booth doesn't set the working directory itself. If it is linked with cluster-glue, the working directory is changed by cluster-glue. Otherwise, if we use libqb, nothing takes care of that. As a result, we have problems with creating temporary files and core dumps.
The changes in this pull request are about creating the active directory /var/lib/booth/cores during installation and setting it during startup, if the application is not linked with cluster-glue.