This repository was archived by the owner on Aug 17, 2024. It is now read-only.
London9 - Ying Xing - Node - Coursework - Week2 #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedsouza99
reviewed
Apr 7, 2023
server.js
Outdated
| res.json(findId); | ||
| console.log(findId); | ||
| } else { | ||
| res.status(404).send("Message not found"); |
server.js
Outdated
| app.get("/messages/:id", function(req, res) { | ||
| const messageId = req.params.id; | ||
| const findId = messages.find((message) => { return message.id === Number(messageId) }); | ||
| if (findId) { |
There was a problem hiding this comment.
Tiny formatting error where "if" isn't lined up with const but don't worry about that for now!
|
|
||
| console.log(newMessage); | ||
| messages.push(newMessage); | ||
| res.status(201).json({ success: true, data: messages }); |
| if (findIndex === -1) { | ||
| res.status(404).send("Message not found"); | ||
| } else { | ||
| messages.splice(findIndex, 1); |
| app.post("/messages", function (req, res) { | ||
| const {from, text} = req.body | ||
| const newMessage = { | ||
| id: messages.length, |
There was a problem hiding this comment.
When setting the ID this way, what would happen if you add 3 messages, deleted the first one, then tried to add another?
ie messages = [1, 2, 3] then remove one -> [2, 3] then try to add a new one -> [2, 3, ?]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?