Expose settings dialog in coda #13937

shardulvs · 2025-12-31T18:25:21Z

Resolves: #
Target version: main

Summary

TODO

...

Checklist

I have run make prettier-write and formatted the code.
All commits have Change-Id
I have run tests with make check
I have issued make run and manually verified that everything looks okay
Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Ibce2d120ffd1675d2801a31538c91d733cccc617

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I1d762dd8fed78aaab0094843a5e388e7aa52d2d3

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I15e5dc65a5a7ee4b3e365d9d13ed1417ed6b09d3

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I587db3002242356112f6541c3feda2f67fb29bbc

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Iae5ca1724380cb823725206a46787941eaa04984

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I8ea52d54a3e8316dfbbf0cbbc30840dcfbffbb8e

- This change replaces the redundant check-box svg logic with actual input check-box Change-Id: Ifd17fcea76770c1a6a27c6df2dac877a5134f915 Signed-off-by: Parth Raiyani <[email protected]>

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Ia606c42771fab9fe8a09ceb888ee37e19f93ed5a

jazevedo-coll · 2025-12-31T18:48:33Z

thanks for this PR!

timar · 2026-01-03T19:15:17Z

browser/Makefile.am

 COOL_IMAGES_CUSTOM_SRC = $(shell if test -n "$(CUSTOM_ICONS_DIRECTORY)"; then find $(CUSTOM_ICONS_DIRECTORY) -name '*.*'; fi)
 COOL_IMAGES_CUSTOM_DST = $(patsubst $(CUSTOM_ICONS_DIRECTORY)/%,$(DIST_FOLDER)/images/%,$(COOL_IMAGES_CUSTOM_SRC))
 COOL_L10N_SRC = $(shell find $(srcdir)/l10n -name '*.json')
-if !ENABLE_MOBILEAPP


This does not look good. In apps (mobile apps and desktop apps) l10n.js does not work. We have to bundle and load all translations at startup.

codewithvk

Thanks @shardul for the PR. However, there are a couple of changes needed.

Current implementation observations:

Currently, all settings files are fetched and uploaded only via the settings iframe. This prevents the settings from being applied for the current session in coolwsd. To apply these changes immediately, we need to load the presets for the relevant settings (code reference: see how this is handled for WOPI in DocumentBroker.cpp::PresetsInstallTask::install).
Since these settings need to be supported across all platforms, it would be better to handle them via a new class under /common. This would allow us to reuse the implementation across platforms almost for free once it’s done for one platform.
When a setting is applied from the options (especially from the File tab backstage), it should take effect immediately. This should be addressed by the first point above. (Session sync problem, not sure possible for all setting file. cc: @caolanm )
I would suggest starting with browser-only settings (which are the most in demand) and making that fully functional first. Adding other sections afterward would be much easier.

codewithvk · 2026-01-06T12:28:43Z

qt/coda-qt.cpp

+#include <Poco/Exception.h>
 #include <config.h>
 #include "bridge.hpp"
 #include "COOLWSD.hpp"


build error: Missing #include <Poco/Environment.h>

codewithvk · 2026-01-06T12:28:52Z

qt/coda-qt.cpp

 * file, You can obtain one at http://mozilla.org/MPL/2.0/.
 */

+#include <Poco/Exception.h>


can we use std::exception?

codewithvk · 2026-01-06T12:33:08Z

browser/admin/src/integrator/AdminIntegratorSettings.ts

 		window.wopiSettingBaseUrl = element.dataset.wopiSettingBaseUrl;
 		window.iframeType = element.dataset.iframeType;
-		window.cssVars = element.dataset.cssVars;
+		// window.cssVars = element.dataset.cssVars;


Do we have any reason to hide this here? It would stop applying branding for other integrator styles.

I removed it because adminintegratorsettings.html was not being preprocessed, which caused an error. I have added preprocessing in coda now, so this is uncommented again

codewithvk · 2026-01-06T13:16:50Z

browser/admin/src/integrator/AdminIntegratorSettings.ts

+				xcu: null,
+			};
+			if ((window.parent as any).ThisIsAMobileApp) {
+				this.populateSharedConfigUI(data);


Why we try to populate data with every sensible filed null?

ConfigData contains URLs of files on the WOPI server, so in the case of CODesktop it is null

codewithvk · 2026-01-06T13:20:42Z

browser/admin/src/integrator/AdminIntegratorSettings.ts

 		const image = document.createElement('img');
-		image.src = `${window.serviceRoot}/browser/${window.versionHash}/admin/images/${imageSrc}`;
+		let src = `${window.serviceRoot}/browser/${window.versionHash}/admin/images/${imageSrc}`;
+		if ((window.parent as any).ThisIsAMobileApp)


I think ThisIsAMobileApp is misleading here; we should use isCODesktop instead.

codewithvk · 2026-01-06T13:27:17Z

browser/admin/adminIntegratorSettings.html.m4

@@ -0,0 +1,72 @@
+m4_dnl -*- Mode: HTML -*-x


Any good reason to convert to m4?

I converted it to m4 because Coda loads HTML from local file paths and has no HTTP backend. m4 expands the exact relative paths for all js/css files so they resolve correctly. same happens in cool.html.m4

The fact is, sooner or later this CODA branch code will be merged into main branch, and I’m afraid it could break the current online.

in case of online the adminIntegratorSettings.html produced from this m4 file should be the exact same as before

codewithvk · 2026-01-06T13:28:25Z

browser/src/map/handler/Map.Settings.ts

 	_getLocalSettingsUrl: function (): string {
 		const settingsLocation: string = app.LOUtil.getURL(
-			'/admin/adminIntegratorSettings.html',
+			'adminIntegratorSettings.html',


Will it affect online? If so, we should add the isCODesktop condition.

I dont think it will affect online as the path is now changed

codewithvk · 2026-01-06T13:38:45Z

browser/Makefile.am

 	select2.js \
 	sanitize-url.js

-if !ENABLE_MOBILEAPP


There’s no need to remove l10n.js here for mobile. The problem with the current code is that adminIntegratorSettings is built with the admin-js bundle. This reminds me of my Hackweek patch (#11775). Similarly, I think we should either extract this into a separate bundle or ignore translations for now.

codewithvk · 2026-01-06T13:44:25Z

qt/coda-qt.cpp

+            Poco::JSON::Parser parser;
+            auto obj = parser.parse(payload).extract<Poco::JSON::Object::Ptr>();
+
+            const std::string fileName = obj->getValue<std::string>("fileName");
+            const std::string filePath = obj->getValue<std::string>("filePath");
+            const std::string content = obj->getValue<std::string>("content");


I think this kind of common, cross-platform code can be moved to /common, similar to how we did it for RecentFiles (https://github.com/CollaboraOnline/online/blob/distro/collabora/coda-25.04/common/RecentFiles.cpp). This would make it much easier to implement and reuse across platforms.

codewithvk · 2026-01-06T13:45:19Z

qt/coda-qt.cpp

+                Poco::Path(base).append("settings/userconfig/browsersetting/browsersetting.json");
+
+            const Poco::Path viewSettingPath =
+                Poco::Path(base).append("settings/userconfig/viewsetting/viewsetting.json");


I would not prefer hardcoded path for every setting files.

The path is already hardcoded in the SettingIframe.PATH object in AdminIntegratorSettings.ts

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I390c6a1e17f9c2414e885c36e1e042157217aaec

shardulvs · 2026-01-09T21:35:26Z

When a setting is applied from the options (especially from the File tab backstage), it should take effect immediately. This should be addressed by the first point above. (Session sync problem, not sure possible for all setting file. cc: @caolanm )

I would suggest starting with browser-only settings (which are the most in demand) and making that fully functional first. Adding other sections afterward would be much easier.

The dark mode and compact mode options in browsersetting now get applied immediately

Shardul Vikram Singh and others added 8 commits December 30, 2025 12:45

Fix: settings.css missing from dist in bundled builds

7fa8de2

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Ibce2d120ffd1675d2801a31538c91d733cccc617

Add padding to settings dialog

a8b7e65

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I1d762dd8fed78aaab0094843a5e388e7aa52d2d3

Add settings dialog navbar

5a53186

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I15e5dc65a5a7ee4b3e365d9d13ed1417ed6b09d3

Make settings dialog draggable

595364d

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I587db3002242356112f6541c3feda2f67fb29bbc

Remove horizontal scrollbar from settings dialog

04839f6

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Iae5ca1724380cb823725206a46787941eaa04984

Add active state to navbar items in settings dialog

9c344e7

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I8ea52d54a3e8316dfbbf0cbbc30840dcfbffbb8e

fix: enhance checkbox accessibility and simplify event handling

ba499cf

- This change replaces the redundant check-box svg logic with actual input check-box Change-Id: Ifd17fcea76770c1a6a27c6df2dac877a5134f915 Signed-off-by: Parth Raiyani <[email protected]>

Move a11y toggle from ViewSettings to InterfaceSettings

3b7580a

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: Ia606c42771fab9fe8a09ceb888ee37e19f93ed5a

github-project-automation bot moved this to To Review in Collabora Online Dec 31, 2025

github-project-automation bot added this to Collabora Online Dec 31, 2025

shardulvs mentioned this pull request Dec 31, 2025

Collabora Office: Expose Settings #13850

Open

This was referenced Dec 31, 2025

Autotext interface to allow adding of entries seems to be non existent on both Collabora Online via Opencloud and Collabora Office Desktop #13914

Open

Add support for third party extensions like Zotero #13670

Open

timar requested changes Jan 3, 2026

View reviewed changes

github-project-automation bot moved this from To Review to In Progress in Collabora Online Jan 3, 2026

codewithvk requested changes Jan 6, 2026

View reviewed changes

Expose Settings dialog in coda-qt

ba694e2

Signed-off-by: Shardul Vikram Singh <[email protected]> Change-Id: I390c6a1e17f9c2414e885c36e1e042157217aaec

shardulvs force-pushed the expose-settings-coda branch from b570299 to ba694e2 Compare January 9, 2026 21:02

shardulvs requested a review from codewithvk January 9, 2026 21:39

Expose settings dialog in coda #13937

Are you sure you want to change the base?

Expose settings dialog in coda #13937

Conversation

shardulvs commented Dec 31, 2025

Summary

TODO

Checklist

Uh oh!

jazevedo-coll commented Dec 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codewithvk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shardulvs commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codewithvk left a comment •

edited

Loading

shardulvs commented Jan 9, 2026 •

edited

Loading