-
Notifications
You must be signed in to change notification settings - Fork 960
private/kendy/coda main batch 1 #13981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kendy
wants to merge
177
commits into
main
Choose a base branch
from
private/kendy/coda-main-batch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
177 commits
Select commit
Hold shift + click to select a range
550d3be
coda-m: Initial macOS app
kendy edc1516
Initial CODA-Windows commits squashed together
adf5259
A few CODA-M commits squashed together
kendy 9c7a803
A few CODA-W commits squashed together
30595ad
Typed access to window.ThisIsThe*App
kendy f58646c
Various CODA-M commits squashed together
kendy 7602d3c
Various CODA-W commits squashed together
266dc44
Various CODA-M commits squashed together
kendy 8fd14ee
Various CODA-W commits squashed together
bc4904d
Various CODA-M commits squashed together
kendy 3baf5da
Lots of changes for CODA-W
8b79de9
coda-m: Update the project to build after the file splits
kendy b3ecbb6
coda-m: Update how the core install is copied to lokit/ subdir
kendy b23fa21
Make FileUtil.cpp compile on Windows
7138d42
coda-m: Better error message here
kendy f6149ce
coda-m: Don't add appDocId, it is iOS-specific
kendy 589b3e1
Make a bunch of source files compile for Windows
e40d22f
Fix compilation errors on Windows
567e644
Use 'Multi-processor Compilation'
9b26890
I build Poco statically, so adapt to that
8489f0d
Misc small changes to make CODA-W build
ac5cac6
Add getter and setter functions for coolwsd_server_socket_fd for CODA-W
dd83df4
Don't warn about VLAs in Windows compilation
bc5daa4
Avoid warnings in CODA-W build: Use Util::getProcessId() instead of g…
8133ce1
A handful of sequential CODA-M commits squashed together
kendy 2f009cd
Improve Util::time_t_to_localtime() and add Util::time_t_to_gmtime()
7edb6ba
Drop some now unneeded Windows-specific defines
2295639
Enable debugging of unmanaged (C++) code in CODA-W
e297574
Some more baby steps to make CODA-W start up properly
eabace7
coda-m: Enable possibility to debug WKWebView from Safari
kendy d0d1a78
coda-m: Get some debug output from send2JS (when enabled)
kendy bbe1151
coda-m: We perform the same restrictions wrt. \n as on iOS
kendy 2df3ab8
Add experimentation with managed/native code marshalling on Windows
ef92091
coda-m: Good to have these debugging possibilities around
kendy 8ae74b3
We do need LO_PATH in CODA-W
ec6ea48
Pass non-null args to lok_init_2() for CODA-W
92f6212
Try to get CODA-W to proceed further
55b33dd
Re-indent a bit to better match our style
c2801f4
Attempt to handle Windows pathnames better
6964cc0
Work on CODA-W, intermediate commit
2c37a8d
Four commits to coda-m squashed together
kendy 8ce74f0
Also check window.ThisIsTheWindowsApp
8df9bb9
Change CODA to use .NET (and not .NET Framework)
50e051c
coda-m: Read the document that the user has choser in File -> Open...
kendy 701d8de
Three CODA-W commits squashed together
84b2c0b
Six CODA-M commits squashed together
kendy 5a3fd4a
Tweak SAL_LOG to avoid some verbiage
6733609
Fix logic in handling the flush option when logging to console
bed7b20
Try to make logging work better in CODA-W
b8721df
Modify the message passing from JS to C# in CODA-W
06d37d2
coda-m: Implement saving from the File -> Save menu in the app
kendy d7e1695
Check for the existence of memrchr
kendy 900a4c4
coda-m: Fix build of WebSocketHandler on macOS
kendy 00116dc
Also set window.userInterfaceMode for CODA-W
0a008e8
Execute JavaScript in the main thread
18bea36
CODA-W debugging hacks
9afe236
Implement Util::setThreadName() for Windows
aa5208d
coda-m: Define MACOS via config.h instead of a project setting
kendy 5595da3
Generalize the check for capabilities to avoid the specific check for…
kendy 4e25d64
Move the CPPFLAGS overwriting to the bottom of configure.ac
kendy 43993d6
Implement pipe2() for platforms that don't have it (like macOS)
kendy 7e7f97f
Avoid "error: unused function" on macOS
kendy 821d3c7
Add HAVE_LIBCAP, HAVE_PIPE2, and MACOS here, too
tml1024 ee68577
Fix build of CODA-W
tml1024 315b47c
Use the built-in predefined _WIN32 macro instead of an own silly _WIN…
tml1024 43c68fe
Make the HAVE_* defines more consistent and improve the comments
kendy 212ed93
This prctl() call is Linux-specific
kendy d93b7e6
Add macOS/iOS implementation of getThreadId()
kendy 326abb7
Define 'environ' on macOS
kendy 323441a
Trivial implementation of mount() and umount2() for macOS
kendy 7069782
coda-m: Update readme
kendy 285c3a2
coda-m: Guard some parts with MOBILEAPP
kendy 9ba4968
Create Syscall.hpp/cpp to wrap various platform-dependent syscalls
kendy db6a7aa
Use the configured LO_PATH in the Run Script phase, instead of a hard…
kendy 694ba75
Implement socket() with CLOEXEC and NONBLOCK for macOS
kendy 1114d02
iOS: NetUtil.* shouldn't be needed for the app
kendy 801dddf
Adapt to the different Homebrew locations on Intel vs Apple Silicon Mac
840c5e8
Implement accept() with CLOEXEC and NONBLOCK for macOS
kendy cb8b8dc
Adapt the getsockopt() calls for macOS
kendy d26c912
Obtaining the current thread ID for macOS
kendy 95b96ae
Update linker flags for macOS
kendy 7b4c083
Temporarily don't check the disk space in the macOS coolwsd
kendy 6ccf72d
Fix linking on macOS
kendy 836c88e
Syscall.hpp is not for the MOBILEAPP case, and does not compile on Wi…
5d9a1fd
This is mobileapp-only
kendy 06947d2
Fix build on macOS
kendy f5daea3
We need libiconv for linking too
kendy a5dfb43
It turns out pkg-config was explicitly disabled on macOS
kendy 17b71e5
Syscall: Cleaner way to not build unecessary code
hfiguiere 57a8756
Fix build of tests on macOS
kendy e4d9004
Check for different versionrc location on macOS
kendy 1cd7539
No debug POCO liraries on macOS
timar 3009412
Add Xcode project for coolwsd for easier debugging
kendy 6382888
Fix return values (and document them too)
kendy 0334718
Actually let's experiment with coolwsd-inproc for the moment
kendy 906b225
Set correct paths for macOS
kendy 823302e
iconv behaves a bit weirdly on macOS
kendy e4aa3bf
Disable SSL in the debug run from Xcode for easier debugging
kendy 7eaea86
coda-m: Fix build
kendy dc00d2a
Refactor in preparation for platform-dependent implementation
kendy bd49af9
Move the (Thread|FD)Counter to Util-linux and provide macOS impl
kendy d1107d5
Separate the coolwsd and coolwsd-inproc schemes
kendy aaf2789
Disable capabilities for coolwsd in Xcode on macOS
kendy f357cc9
coda-m: Introduce ENABLE_CHILDROOTS & guard it by --enable-coda
kendy 71c58ad
coda-m: Add more coolwsd source files to the project
kendy 2804a0c
Consolidate the ifdef
kendy f256292
coda-m: Fix most of the linking issues (but some are still left)
kendy 5656092
coda-m: COOLWS is not supposed to be run twice
kendy 76d6044
coda-m: Read coolwsd.xml from the bundle's Resources
kendy 347c80f
coda-m: Disable the COOLWSD main() not to conflict
kendy 1c3b7d4
coda-m: Pass the options needed for the coolwsd-inside-CODA functiona…
kendy 14b1cc5
coda-m: Update README to match the current developments
kendy e1ca335
coda-m: Handle discovery.xml
kendy 43e42ac
coda-m: Add Incoming connections (Server) entitlement
kendy 0b353cc
Drop acidental extra slash
tml1024 6fbcd50
Construct a file: Poco::URI by passing a Poco::Path
tml1024 6734dbb
Windows-specific pathname fixes
tml1024 3b71205
Silence one more verbose INFO log tag
tml1024 bd7e969
coda-m: Fix the build of normal coolwsd on macOS again
kendy 64de503
It's only CODA-M that handles the MODIFIED message for now
tml1024 c2e0cbd
Handle the abstract vs. regular socket names transparently
kendy fb58a01
coda-m: More places to disable when we don't use childroots
kendy 2f6056e
coda-m: Update the Xcode project
kendy db83041
coda-m: No need to guard this by ENABLE_CODA any more
kendy 8fa1939
Filter out more noisy and presumably pointless INFO and WARN log
tml1024 86148ca
Make CODA depend on CODALib
tml1024 ef755e2
Drop final backslash from return value of getSysTempDirectoryPath()
tml1024 4c33dd7
Make the CODA-W config.h.in match the Linux one more closely
tml1024 943f853
Add CODA-W specific generated files and project directories
tml1024 fdab4ab
Replace meaningless rubbish with simple code that works
tml1024 110bae0
coda-m: Introduce project for coolforkit
kendy aa46f86
coda-m: Revert back to the --enable-macosapp approach
kendy f902c65
coda-m: Better look via branding.(js,css)
kendy 85413d3
coda-m: Icon for the bundle
kendy 2b3ad29
coda-m: Make the hyperlinks work
kendy b43220d
Enable JS debugging again in the CODA-W project
28fdd00
Add branches for the Windows app, too to the clipboard code
866ed9b
Provide default params for Log::initialize() to simplify callers
kendy 849b04a
coda-m: Make the Xcode project build against 25.04
kendy 7996f93
coda-m: Trivial documentation update
kendy 7c185ba
Tune the launch settings for CODA in Visual Studio a bit
12cdbeb
Change libpng library name to match that built in LO
209bd6b
Improve CODA-W build instructions
b31bd66
coda-m: Proof of concept Bold/Italic/Underline menu items
kendy fc3bf47
coda-m: Add branding how-to
kendy 4962ce9
We also need zlib, libpng, and cppunit for CODA-M
714c8f5
Update WebView2 to the current version, as VS suggests
6f2dcf8
Start adding a native menu to CODA-W
c973440
coda-m: Show the state of Bold/Italics/Underline in the menu
kendy f05548c
Don't use a hardcoded document name but make the File>Open menu entry…
89a6553
Hide also the XAML menu once cool.html is displayed with its own menu
1e04a55
coda-m: Implement printing from the application's menu
kendy 16e34b6
coda-m: Trigger printing also from the notebookbar
kendy 7fa614d
Add File>Quit
e350d0a
Send the PRINT message also in the CODA-W case
20dbff2
Drop unused KitWebSocketHandler::getKitId()
f351bf4
Fix comment
c37b0e7
Improve the "app document id" handling in CODA-W
dc57e68
coda-m: Make the printing work
kendy d588d4d
coda-m: Avoid executables from core & limit resulting architecture
kendy 1cb32cb
coda-m: Enable Hardened runtime, to be able to build a package
kendy 4b9601f
Implement File > Print in CODA-W
b1164b8
Fix CODA-W build after rebase
0f53485
Show a print dialog
f201d7d
coda-m: Implement clipboard Copy (no Paste yet)
kendy f32937d
coda-m: Implement clipboard Paste
kendy 9fc035d
coda-m: Enable/disable the Cut/Copy/Paste in the macOS menu
kendy 4c6a27a
Use Util::getProcessId() instead of getpid()
9c77895
Add RegexUtil.cpp
1f35117
OutDir should end with a backslash
d4f680f
Copy browser/dist to the output directory and use it from there
tml1024 2bcd748
Copy also the LO instdir into the app folder and use it from there
tml1024 8f56390
Don't use Windows Forms API to get the folder we are running from
0af5956
Bin the temporary DllImportTest thing
1e8cc6d
coda-m: Remove the 'MODIFIED (true|false)' message again
kendy 6be7f43
coda-m: Fix crash when auto-saving non-modified document
kendy 1eb4459
./g review should use --force-with-lease
kendy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Set correct paths for macOS
Signed-off-by: Jan Holesovsky <kendy@collabora.com> Change-Id: I86e47fe655f462f969ff6d44a43dd5c03b3be253
- Loading branch information
commit 906b225ec858d33a7819a03b446051d40b2dce3d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / CodeQL
FIXME comment Note
Copilot Autofix
AI 4 days ago
In general, to fix this kind of issue you either (a) implement the missing, correct behavior for the relevant platform(s), or (b) if that platform is not actually supported, remove the FIXME and replace it with a clear compile-time or runtime error indicating that the configuration is unsupported. That removes ambiguous behavior and the FIXME.
In this case, the preceding branches already explicitly cover Linux (non-Android), FreeBSD, MACOS (MOBILEAPP), IOS, and Windows. The
#elsebranch therefore applies to any other MOBILEAPP platform, most plausibly Android, but Android is already excluded in the Linux condition via!defined(__ANDROID__), and there is no Android-specific path here. If Android is not supported for this Kit binary, the safest and most explicit fix is to disallow compilation for unknown platforms in this block and avoid callinglok_init_2(nullptr, nullptr)with unclear semantics.The single best minimal-impact change is:
#elseblock that contains the FIXME and thelok_init_2(nullptr, nullptr)call with a compile-time#errorfor unknown/unsupported platforms. This removes the FIXME comment, prevents accidental builds on untested platforms, and does not change behavior on currently supported platforms. Since we must keep changes withinkit/Kit.cppand within shown snippets, we only modify lines 3967–3968, inserting a preprocessor#errorline instead of the questionable initialization.No additional imports or methods are needed; this is purely a preprocessor-branch and comment fix.