make theme specifying possible through richdocuments #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpranam
force-pushed
the
theme
branch
3 times, most recently
from
2ca902a to
0fd0b03
Compare
3 tasks
Signed-off-by: Pranam Lashkari <[email protected]> Change-Id: I3e6e837464069330975cb377ec0126c5d61477ef
Member
|
Tested and works as expected, though the only limitation with that approach seems to be that the loleaflet.html file would be preprocessed so changing the parameter after loading once will not have any effect, though that may be acceptable unless the COOL server is used for multiple integrators. |
Contributor
|
@juliushaertl: The file is preprocessed with every request (due to the access token etc.), not just once & served the same all the time (if that was your concern?) - os I hope this shouldn't be a problem. |
kendy
approved these changes
Oct 11, 2021
Contributor
kendy
left a comment
kendy
left a comment
There was a problem hiding this comment.
Looks great to me - thank you!
Member
|
Ok, then this was just due to the fact that i tried with the same access token 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pranam Lashkari [email protected]
Change-Id: I3e6e837464069330975cb377ec0126c5d61477ef
Checklist
make checkmake runand manually verified that everything looks okay