Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Comfy-Org/ComfyUI_frontend
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8871ea6
Choose a base ref
...
head repository: Comfy-Org/ComfyUI_frontend
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ec5db87
Choose a head ref
  • 12 commits
  • 249 files changed
  • 10 contributors

Commits on Dec 8, 2025

  1. When moving subgraphInput link, properly disconnect old link (#7229)

    When moving an existing link with subgraphInput as source to a new node,
    the prior link is removed, but the previous target node would not have
    it's link property cleared.
    
    Resolves #7225
    
    Also re-enables several functional skipped tests.
    
    It feels like I'm having to play whack-a-mole reimplementing the same
    fixes on every permutation of subgraphIO links. I'd like to setup up a
    unified test set that covers them all, but wouldn't want the added work
    to further delay this fix.
    
    ┆Issue is synchronized with this [Notion
    page](https://www.notion.so/PR-7229-When-moving-subgraphInput-link-properly-disconnect-old-link-2c36d73d36508149aca0ce477fee5c9e)
    by [Unito](https://www.unito.io)
    AustinMroz authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    248929c View commit details
    Browse the repository at this point in the history
  2. Fix job details popover sticking after cancel/delete (#6930)

    ## Summary
    - close the job details popover when its job disappears or timers fire
    after list changes, and clear hover timers on unmount
    - emit an explicit details-leave on cancel/delete clicks so the popover
    closes even if hover-out never fires
    
    Fixes #6907
    
    ┆Issue is synchronized with this [Notion
    page](https://www.notion.so/PR-6930-Fix-job-details-popover-sticking-after-cancel-delete-2b66d73d365081dc990ae87d01455bad)
    by [Unito](https://www.unito.io)
    benceruleanlu authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    97c7b33 View commit details
    Browse the repository at this point in the history
  3. Hotfix: Templates spec (#7235)

    ## Summary
    
    Top row of templates no longer contains an Image Generation. That's
    interesting, huh?
    DrJKL authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    dd7e7e7 View commit details
    Browse the repository at this point in the history
  4. 1.34.7 (#7236)

    Patch version increment to 1.34.7
    
    **Base branch:** `main`
    
    ┆Issue is synchronized with this [Notion
    page](https://www.notion.so/PR-7236-1-34-7-2c36d73d365081799e62e92ba60adacf)
    by [Unito](https://www.unito.io)
    
    ---------
    
    Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    3 people authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    63592af View commit details
    Browse the repository at this point in the history
  5. Hotfix: restore cancel button in top menu (#7234)

    ## Summary
    - restore the interrupt/cancel button in the top menu action bar
    
    ┆Issue is synchronized with this [Notion
    page](https://www.notion.so/PR-7234-Hotfix-restore-cancel-button-in-top-menu-2c36d73d365081b18dede1e49183a429)
    by [Unito](https://www.unito.io)
    
    ---------
    
    Co-authored-by: github-actions <github-actions@github.com>
    benceruleanlu and github-actions authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    259e956 View commit details
    Browse the repository at this point in the history
  6. fix: Refresh model dropdowns after upload (#7232)

    ## Summary
    Model selection dropdowns now automatically refresh after uploading a
    new model, ensuring users see newly uploaded models immediately.
    
    ## Changes
    - **Cache Orchestration**: Upload wizard now refreshes model caches by
    coordinating between `modelToNodeStore` and `assetsStore`
    - **Smart Refetching**: Only refreshes node types that use the uploaded
    model category (e.g., uploading a checkpoint refreshes
    `CheckpointLoaderSimple` but not `LoraLoader`)
    - **Clean Architecture**: Stores remain decoupled - the upload wizard
    composable orchestrates the refresh logic
    
    ## Technical Details
    After successful upload, `useUploadModelWizard`:
    1. Gets all node providers for the model type from `modelToNodeStore`
    2. Calls `assetsStore.updateModelsForNodeType()` for each affected node
    type
    3. Model dropdowns reactively update via Pinia store watchers
    
    ## Review Focus
    - Orchestration pattern in upload wizard keeps stores decoupled
    - Efficient cache invalidation - only refreshes affected node types
    
    ---------
    
    Co-authored-by: Claude <noreply@anthropic.com>
    Co-authored-by: Alexander Brown <drjkl@comfy.org>
    3 people authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    973d767 View commit details
    Browse the repository at this point in the history
  7. Tests: Playwright test timeouts (#7231)

    ## Summary
    
    See where we can use proper DOM waiting instead of waitForTimeout.
    
    ┆Issue is synchronized with this [Notion
    page](https://www.notion.so/PR-7231-WIP-Playwright-test-timeouts-2c36d73d3650812b966ac3d9c338dfd4)
    by [Unito](https://www.unito.io)
    DrJKL authored Dec 8, 2025
    Configuration menu
    Copy the full SHA
    5c01861 View commit details
    Browse the repository at this point in the history
  8. style: Remove most font-family definitions, set to Inter on body

    style: More Inter replacing Arial
    Remove special fonts for tests
    DrJKL committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    3e606fa View commit details
    Browse the repository at this point in the history
  9. Update src/renderer/extensions/vueNodes/widgets/composables/useImageP…

    …reviewWidget.ts
    
    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    DrJKL and coderabbitai[bot] committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    b7e1f89 View commit details
    Browse the repository at this point in the history
  10. Update src/lib/litegraph/src/canvas/InputIndicators.ts

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    DrJKL and coderabbitai[bot] committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    c9cb42f View commit details
    Browse the repository at this point in the history
  11. Update src/lib/litegraph/src/subgraph/SubgraphIONodeBase.ts

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    DrJKL and coderabbitai[bot] committed Dec 8, 2025
    Configuration menu
    Copy the full SHA
    034a102 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2025

  1. Configuration menu
    Copy the full SHA
    ec5db87 View commit details
    Browse the repository at this point in the history
Loading