[Bug]: Promoted widget on parent SubgraphNode not renamed when SubgraphInputNode slot is renamed #4847
Description
Prerequisites
- I am running the latest version of ComfyUI
- I have searched existing issues to make sure this isn't a duplicate
- I have tested with all custom nodes disabled
What happened?
When you enter a subgraph, connect a widget to the SubgraphInputNode, then right-click on the created slot and select "Rename Slot", the promoted widget on the parent SubgraphNode does not get renamed to reflect the new slot name. The widget retains its original name despite the slot being successfully renamed.
Steps to Reproduce
- Create a subgraph or enter an existing one
- Add a node with a widget (e.g., a KSampler with a "seed" widget)
- Connect the widget to the SubgraphInputNode - this creates a new slot and promotes the widget to the parent SubgraphNode
- Right-click on the newly created slot on the SubgraphInputNode
- Select "Rename Slot" and give it a new name (e.g., "my_custom_seed")
- Exit the subgraph to view the parent SubgraphNode
- Observe that the promoted widget still shows the original name (e.g., "seed") instead of the new slot name ("my_custom_seed")
How is this affecting you?
Feature doesn't work as expected
ComfyUI Frontend Version
1.26.0
Browser
Chrome/Chromium
Console Errors
No console errors are generated - this is a logic issue where the widget name update is not propagated.
Additional Context
This issue occurs because in , the event listener for only updates the widget's property but not the property. Both properties need to be updated to maintain consistency.
The fix would involve updating line 129 in SubgraphNode.ts to also set along with the existing .
Related to subgraph functionality but distinct from issue #4834 which is about stale content in the rename dialog.
┆Issue is synchronized with this Notion page by Unito