-
Notifications
You must be signed in to change notification settings - Fork 451
Description
Prerequisites
- I am running the latest version of ComfyUI
- I have searched existing issues to make sure this isn't a duplicate
- I have tested with all custom nodes disabled
What happened?
When the link release action setting is set to "no action", there's an inconsistent behavior between SubgraphInputNode connections and regular node-to-node connections:
- SubgraphInputNode → Node connection: When disconnecting from the node's slot and dropping on empty canvas, the link snaps back to the slot (reverts the disconnection)
- Node → Node connection: When performing the same action with the same setting, the connection is broken/deleted
This inconsistency makes the "no action" setting behave unexpectedly depending on the type of connection.
Steps to Reproduce
- Go to Settings and set "Link Release Action" to "No Action"
- Create or enter a subgraph
- Connect a SubgraphInputNode output to any regular node input
- Exit the subgraph to see the parent view
- Try to disconnect the link by dragging from the node's input slot and dropping on empty canvas
- Observe: The link snaps back to the slot (connection is preserved)
- Now create two regular nodes and connect them
- Try to disconnect the link by dragging from one slot and dropping on empty canvas
- Observe: The connection is broken/deleted (inconsistent with step 6)
How is this affecting you?
Feature doesn't work as expected
ComfyUI Frontend Version
1.26.0
Browser
Chrome/Chromium
Console Errors
No console errors are generated - this is a behavioral inconsistency issue.
Additional Context
The root cause appears to be in . The method (line 631) doesn't dispatch a event like other drop methods do:
- dispatches
- dispatches
- dispatches
- dispatches nothing
This missing event dispatch prevents the link release action handler from being triggered for SubgraphInputNode/SubgraphOutputNode connections, causing the inconsistent behavior.
The fix would involve adding an appropriate event dispatch in the method to ensure consistent behavior across all node types.
┆Issue is synchronized with this Notion page by Unito