Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
d4ea383
feat(app-mode): layout grid primitive + system cells (Phase 1)
eliheuer Apr 16, 2026
96330d5
feat(bento): Phase 2a — per-input cells with uniform width
eliheuer Apr 14, 2026
0d31e3b
feat(bento): Phase 2b — per-output cells + design tokens
eliheuer Apr 14, 2026
43302f8
feat(app-mode): semi-customizable floating panels MVP (Phase 4)
eliheuer Apr 16, 2026
7da9659
style(app-mode): Phase 4 polish — typography, spacing, panel chrome
eliheuer Apr 16, 2026
451752b
refactor(app-mode): rename bento/ -> layout/
eliheuer Apr 16, 2026
1d16073
feat(app-mode): welcome screen — wordmark, copy, Run pill
eliheuer Apr 16, 2026
dde524f
feat(app-mode): unified chrome — shared sidebar + panel-matched cells
eliheuer Apr 16, 2026
8f8aa62
style(app-mode): flush left-dock + surface Run errors as toast
eliheuer Apr 16, 2026
a4addaa
i18n(app-mode): route output-thumb alt + block-drag aria-label throug…
eliheuer Apr 16, 2026
e28af8c
feat(app-builder): WYSIWYG floating panel shared with App Mode
eliheuer Apr 17, 2026
d9ae0dd
feat(app-mode): hoist Run cluster out of panel + mirror welcome copy
eliheuer Apr 17, 2026
c9b8e53
Merge branch 'main' into app-mode-semi-customizable-layout
DrJKL Apr 21, 2026
299292a
refactor(app-mode): address PR review feedback
eliheuer Apr 22, 2026
d436f54
fix(app-mode): second-round CodeRabbit feedback
eliheuer Apr 22, 2026
385b611
fix(app-mode): third-round CodeRabbit feedback
eliheuer Apr 22, 2026
9657403
Merge branch 'main' into app-mode-semi-customizable-layout
eliheuer Apr 22, 2026
3361a66
refactor(app-mode): unify App Mode and Builder chrome + panel
eliheuer Apr 23, 2026
3b70a54
refactor(app-mode): one grid system — fixed-gutter flex zones
eliheuer Apr 23, 2026
551a702
polish(app-builder): grid-aligned chrome bars + unified blue / orange…
eliheuer Apr 23, 2026
76dc717
polish(app-builder): highlight selectable widgets in builder:inputs
eliheuer Apr 23, 2026
550d855
polish(app-builder): output-selection parity + footer cleanup
eliheuer Apr 23, 2026
9adcea8
polish(app-mode): go/stop semantic cluster + run progress bar
eliheuer Apr 23, 2026
916ad31
refactor(app-mode): route go/stop colors through local CSS vars
eliheuer Apr 23, 2026
d621c7d
chore(app-mode): pre-squash CR-pattern cleanup
eliheuer Apr 23, 2026
69e1bff
Merge remote-tracking branch 'upstream/main' into app-mode-semi-custo…
eliheuer Apr 23, 2026
82f1980
chore(app-mode): pre-squash cleanup from .agents/checks audit
eliheuer Apr 23, 2026
fd022de
refactor(app-mode): unify App Builder and App Mode into one WYSIWYG s…
eliheuer Apr 23, 2026
e8c7076
chore: drop unused type exports flagged by knip
eliheuer Apr 23, 2026
38b197c
polish(app-mode): pre-draft-flip panel UX pass
eliheuer Apr 23, 2026
adc1db4
chore(app-mode): pre-review code-quality cleanup pass
eliheuer Apr 24, 2026
fbddb28
Merge remote-tracking branch 'upstream/main' into app-mode-semi-custo…
eliheuer Apr 24, 2026
d1f29f0
polish(app-mode): workspace pan/zoom + nav cluster + welcome touch-up
eliheuer Apr 24, 2026
32ab581
polish(app-mode): panel-block reorder — architecture + visuals
eliheuer Apr 24, 2026
583ba29
polish(app-mode): phase-3 drag demo + accent sweep
eliheuer Apr 26, 2026
0628acf
feat(app-mode): output preview as a movable window
eliheuer Apr 26, 2026
7c0d078
feat(app-mode): migrate run chrome into OutputWindow
eliheuer Apr 26, 2026
ccf166d
chore(app-mode): drop dead Interrupt/Progress cells
eliheuer Apr 26, 2026
4083442
feat(app-mode): multi-window output workspace (scaffolding)
eliheuer Apr 26, 2026
f067835
refactor(app-mode): drop the thumbnail history strip
eliheuer Apr 27, 2026
fc8e2f3
feat(app-mode): multi-window polish — asset resolution + close + clea…
eliheuer Apr 27, 2026
09d6ff6
polish(app-mode): UI pass — panel/window chrome, widget outlines, aut…
eliheuer Apr 27, 2026
8f3b9be
polish(app-mode): output overlay + widget chrome refinements
eliheuer Apr 27, 2026
d2e637b
polish(app-mode): floating-panel layout fixes + pre-review cleanup
eliheuer Apr 27, 2026
98f57a9
polish(app-mode): pan reliability + drag perf + dot-grid polish
eliheuer Apr 27, 2026
8c3fb37
polish(app-mode): address outstanding review nits
eliheuer Apr 27, 2026
a4128c8
docs(app-mode): defer agent design-system discoverability work
eliheuer Apr 27, 2026
ea0601a
chore(app-mode): comment trim pass for review (-343 lines)
eliheuer Apr 27, 2026
201fc1e
polish(app-mode): progress bar tracks sampler + window snap during drag
eliheuer Apr 27, 2026
bd4f9ef
chore(app-mode): trim small net-new files (-82 lines)
eliheuer Apr 27, 2026
17ecf38
refactor(app-mode): extract shared PanelHeader component
eliheuer Apr 27, 2026
895c0c1
refactor(app-mode): extract usePointerDrag base hook
eliheuer Apr 28, 2026
56bbd35
chore(app-mode): trim PR-added comments in modified files (-15 lines)
eliheuer Apr 28, 2026
d8355f4
chore(app-mode): drop remaining `!` Tailwind in chrome cells
eliheuer Apr 28, 2026
543f4b3
chore(app-mode): address CR review nits (batch 1/3)
eliheuer Apr 28, 2026
75b77b0
chore(app-mode): address CR review minors (batch 2/3)
eliheuer Apr 28, 2026
d676184
fix(app-mode): address CR review majors (batch 3/3)
eliheuer Apr 28, 2026
ed93de5
docs(app-mode): drop stale check count in discoverability note
eliheuer Apr 28, 2026
36c23a6
test(app-mode): fix LinearWelcome tests broken by run-pill addition
eliheuer Apr 28, 2026
ff60b57
polish(builder): step badges + Preview-step layout
eliheuer Apr 28, 2026
1289e61
refactor(app-mode): drop temp accent/active tokens for design-system
eliheuer Apr 28, 2026
d4dc570
refactor(builder): unify selection chrome, drop zoom-dependent sizing
eliheuer Apr 28, 2026
f6a29be
refactor(design-system): fold layout tokens into style.css
eliheuer Apr 28, 2026
c497c8c
refactor(design-system): consolidate App Mode tokens, drop README
eliheuer Apr 28, 2026
90f140b
chore(app-mode): trim noisy comments across new files
eliheuer Apr 28, 2026
563742f
feat(app-mode): resize OutputWindow, smooth fly-to, grid-edge spawn
eliheuer Apr 29, 2026
1d16598
feat(app-mode): align panel widgets + metadata-driven subtitle
eliheuer Apr 29, 2026
61ff478
refactor(app-mode): extract FLIP composable, persist panel layout
eliheuer Apr 29, 2026
d434a0d
chore(app-mode): comment sweep + LinearArrange refactor
eliheuer Apr 29, 2026
91bd183
refactor(app-mode): center welcome card; drop side-flip machinery
eliheuer Apr 29, 2026
b007a55
fix(app-mode): drop double focus-ring on widget pills
eliheuer Apr 29, 2026
676a443
Merge branch 'main' into app-mode-semi-customizable-layout
DrJKL Apr 29, 2026
13b3e09
feat(app-mode): no-zoom dashboard mode with adaptive bento layout
eliheuer Apr 30, 2026
6f91765
feat(app-mode): add slicing-tree bento candidate
eliheuer Apr 30, 2026
2a21d12
fix(app-mode): snap dashboard tiles to chrome cell grid
eliheuer Apr 30, 2026
c274133
feat(app-mode): fill canvas via slicing-tree + stretch + cover-fit
eliheuer Apr 30, 2026
0d18fe0
feat(app-mode): asymmetric bento stretch — newest tile uncropped
eliheuer May 1, 2026
8f00acb
feat(app-mode): cap dashboard at 9 tiles, full slicing-tree always
eliheuer May 1, 2026
5edcdf8
fix(app-mode): drop the 8px body padding around output images
eliheuer May 1, 2026
274d32c
fix(app-mode): N=1 stays uncropped, anchored opposite the panel
eliheuer May 1, 2026
152653a
refactor(app-mode): rebuild dashboard layout for visual fidelity
eliheuer May 1, 2026
1f0cfea
feat(app-mode): bento templates fill avail rect, hide header on small…
eliheuer May 1, 2026
de52814
refactor(app-mode): clean up output header chrome + fix panel-drag fr…
eliheuer May 1, 2026
4754980
style(app-mode): match input-cell label/subtitle type, breathe out te…
eliheuer May 1, 2026
681a959
feat(app-mode): theme toggle, zoom-mode parity, gradient skeletons
eliheuer May 2, 2026
989754e
Merge remote-tracking branch 'upstream/main' into app-mode-semi-custo…
eliheuer May 6, 2026
4fb60b8
refactor(app-mode): use palette tokens instead of local --app-mode-* …
eliheuer May 6, 2026
2746856
refactor(app-mode): tighten design-system conformance
eliheuer May 6, 2026
9c171c1
refactor(app-mode): conformance pass per AGENTS.md
eliheuer May 6, 2026
055e46e
refactor(app-mode): minor cleanups from deep audit
eliheuer May 7, 2026
2640d09
lint(autofix): tailwind class order in files using foreground tokens
eliheuer May 7, 2026
c6cf567
test(app-mode): include layout.panelRows in linearData expectations
eliheuer May 7, 2026
fd75632
test(app-mode): unit coverage for new store math
eliheuer May 7, 2026
1acdb42
refactor(app-mode): scope foreground tokens to App Mode via arbitrary…
eliheuer May 7, 2026
a4d4145
Revert "lint(autofix): tailwind class order in files using foreground…
eliheuer May 7, 2026
1a7300b
lint(autofix): canonical class names in pre-existing files
eliheuer May 7, 2026
7e5a95a
fix(app-mode): evict by createdSeq, not mutable zIndex
eliheuer May 7, 2026
6b9dfe8
fix(test): pass ComfyPage to reSaveAs instead of dereferencing Locator
eliheuer May 7, 2026
f357c57
fix(app-mode): spread graphNodes shallowRef on every assignment
eliheuer May 7, 2026
c668618
fix(app-mode): disable manual drag/resize on output windows in noZoom…
eliheuer May 7, 2026
4c140cb
fix(app-mode): don't silently rerun current graph when output has no …
eliheuer May 7, 2026
1a1025b
fix(app-mode): scope wheel-zoom to the workspace, leave panel scroll …
eliheuer May 7, 2026
c48d731
fix(app-mode): keep full-viewport backdrop hit-testable for pan/zoom
eliheuer May 7, 2026
5a31405
fix(app-mode): address 5 minor CodeRabbit findings
eliheuer May 7, 2026
2f7e90a
fix(app-mode): address 5 load-bearing CodeRabbit findings (round 2)
eliheuer May 8, 2026
7a5e375
docs(adr): add 0009 App Mode + Builder unification; format pass
eliheuer May 9, 2026
c997195
fix(app-mode): address round-3 CodeRabbit findings (5 follow-ons + 4 …
eliheuer May 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(app-mode): address CR review majors (batch 3/3)
Accessibility:
- style.css: keyboard focus indicator was killed by `outline: none`
  on `:focus`. Restore a visible 2px outline on `:focus-visible` for
  inputs / textareas / pill widgets so keyboard users see the active
  control (WCAG 2.4.7).

Correctness:
- BuilderBackdrop pan: add `e.preventDefault()` on pointerdown,
  wrap `setPointerCapture` in try/catch, release the capture on
  endDrag, and abandon on window blur — matches LayoutView's pan
  hardening so a pan can't get stuck waiting for a pointerup.
- AppBuilder.nodeToDisplayTuple: string-normalize both sides of the
  selectedOutputs match, mirroring the other handlers in this file.
  After save/load the same logical NodeId can flip primitive type;
  strict equality made already-selected outputs render as
  unselected and re-exposed the add button.

Architecture (Command-pattern):
- appModeStore: add toggleSelectedInput / toggleSelectedOutput /
  removeSelectedOutput helpers as the single entry points for
  selection mutations.
- AppBuilder: route handleClick + the add/remove overlay buttons
  through those store helpers instead of pushing/splicing the
  arrays directly. Drops the now-unused `remove` import.

Documented follow-up:
- AppOutput RAF loop: comment notes that mounting is already gated
  by `isSelectOutputsMode`; centralizing into a shared per-canvas
  RAF dispatcher across all AppInput/AppOutput instances is the
  right architectural fix but is out of scope for this PR.
  • Loading branch information
eliheuer committed Apr 28, 2026
commit d67618458f29ec45ae02464d14af65929e6ba7a9
14 changes: 10 additions & 4 deletions src/assets/css/style.css
Comment thread
eliheuer marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@
background-color: rgb(255 255 255 / 0.1);
}

/* Active border lifts from 0.08 → 0.18 (perceptible, not loud). */
/* Active border lifts from 0.08 → 0.18 (perceptible, not loud). The
`outline: none` is mouse-focus only — keyboard focus restores a
high-contrast outline below (WCAG 2.4.7 / a11y). */
:is(.floating-panel, .app-chrome) textarea:focus,
:is(.floating-panel, .app-chrome) input:focus,
:is(.floating-panel, .app-chrome)
Expand All @@ -106,10 +108,14 @@
outline: none;
box-shadow: none;
}

/* Restore a visible focus indicator for keyboard navigation. */
:is(.floating-panel, .app-chrome) textarea:focus-visible,
:is(.floating-panel, .app-chrome) input:focus-visible {
outline: none;
box-shadow: none;
:is(.floating-panel, .app-chrome) input:focus-visible,
:is(.floating-panel, .app-chrome)
.bg-component-node-widget-background:has(:focus-visible) {
outline: 2px solid rgb(255 255 255 / 0.7);
outline-offset: 1px;
}

/* NodeWidgets' wrapper-level focus-within:ring leaked past the inner
Expand Down
29 changes: 9 additions & 20 deletions src/components/builder/AppBuilder.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* Gated on `isSelectMode` (only inputs + outputs) and skipped when Vue
* nodes are enabled — Vue nodes handle their own click selection.
*/
import { remove } from 'es-toolkit'
import { computed, ref, toValue } from 'vue'
import type { MaybeRef } from 'vue'

Expand Down Expand Up @@ -114,11 +113,7 @@ function handleClick(e: MouseEvent) {
if (!isSelectOutputsMode.value) return
if (!node.constructor.nodeData?.output_node)
return canvasInteractions.forwardEventToCanvas(e)
const index = appModeStore.selectedOutputs.findIndex(
(id) => String(id) === String(node.id)
)
if (index === -1) appModeStore.selectedOutputs.push(node.id)
else appModeStore.selectedOutputs.splice(index, 1)
appModeStore.toggleSelectedOutput(node.id)
return
}
if (!isSelectInputsMode.value || widget.options.canvasOnly) return
Expand All @@ -127,21 +122,20 @@ function handleClick(e: MouseEvent) {
const storeName = isPromotedWidgetView(widget)
? widget.sourceWidgetName
: widget.name
const index = appModeStore.selectedInputs.findIndex(
([nodeId, widgetName]) =>
String(storeId) === String(nodeId) && storeName === widgetName
)
if (index === -1) appModeStore.selectedInputs.push([storeId, storeName])
else appModeStore.selectedInputs.splice(index, 1)
appModeStore.toggleSelectedInput(storeId, storeName)
}

function nodeToDisplayTuple(
n: LGraphNode
): [NodeId, MaybeRef<BoundStyle> | undefined, boolean] {
// String-normalize both sides — NodeId is `string | number` and the
// same logical ID can flip primitive type across save/load (the
// reason handleClick + the remove handler also do this).
const sid = String(n.id)
return [
n.id,
getBounding(n.id),
appModeStore.selectedOutputs.some((id) => n.id === id)
appModeStore.selectedOutputs.some((id) => String(id) === sid)
]
}

Expand Down Expand Up @@ -251,12 +245,7 @@ const renderedInputCandidates = computed(() => {
'size-full cursor-pointer rounded-lg p-2',
'bg-(--color-app-mode-active-temp)'
]"
@click.stop="
remove(
appModeStore.selectedOutputs,
(k) => String(k) === String(key)
)
"
@click.stop="appModeStore.removeSelectedOutput(key)"
@pointerdown.stop
>
<!-- Inline SVG (see AppInput.vue for rationale) so we
Expand All @@ -282,7 +271,7 @@ const renderedInputCandidates = computed(() => {
'bg-component-node-background',
'ring-4 ring-(--color-app-mode-active-temp-half) ring-inset'
]"
@click.stop="appModeStore.selectedOutputs.push(key)"
@click.stop="appModeStore.toggleSelectedOutput(key)"
@pointerdown.stop
/>
</div>
Expand Down
25 changes: 22 additions & 3 deletions src/components/builder/BuilderBackdrop.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* Shares `appModeStore.viewport*` with App Mode so zoom level
* survives a round trip.
*/
import { useEventListener } from '@vueuse/core'
import { useEventListener, useWindowFocus } from '@vueuse/core'
import { storeToRefs } from 'pinia'
import { computed, useTemplateRef } from 'vue'
import { computed, useTemplateRef, watch } from 'vue'

import { useAppMode } from '@/composables/useAppMode'
import LinearPreview from '@/renderer/extensions/linearMode/LinearPreview.vue'
Expand Down Expand Up @@ -40,6 +40,7 @@ let dragging = false

function handlePointerDown(e: PointerEvent) {
if (e.button !== 0 && e.button !== 1) return
e.preventDefault()
dragStart = { x: e.clientX, y: e.clientY, pointerId: e.pointerId }
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

Expand All @@ -49,19 +50,37 @@ useEventListener(window, 'pointermove', (e: PointerEvent) => {
const dx = e.clientX - dragStart.x
const dy = e.clientY - dragStart.y
if (dx * dx + dy * dy < DRAG_THRESHOLD_PX * DRAG_THRESHOLD_PX) return
bgRef.value?.setPointerCapture(dragStart.pointerId)
try {
bgRef.value?.setPointerCapture(dragStart.pointerId)
} catch {
// Some browsers reject capture on non-primary pointers.
}
dragging = true
}
appModeStore.panBy(e.movementX, e.movementY)
})

function endDrag() {
if (dragStart && dragging) {
try {
bgRef.value?.releasePointerCapture(dragStart.pointerId)
} catch {
// pointer may already be released
}
}
dragStart = null
dragging = false
}
useEventListener(window, 'pointerup', endDrag)
useEventListener(window, 'pointercancel', endDrag)

// Abandon on window blur so a pan can't get stuck waiting for a
// pointerup that never arrives (alt-tab, OS modal).
const focused = useWindowFocus()
watch(focused, (nowFocused) => {
if (!nowFocused && dragStart !== null) endDrag()
})

const workspaceTransform = computed(
() =>
`translate(${viewportOffsetX.value}px, ${viewportOffsetY.value}px) ` +
Expand Down
9 changes: 9 additions & 0 deletions src/renderer/extensions/linearMode/AppOutput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ const isPromoted = computed(() =>
// applied as a CSS transform on TransformPane and doesn't fire the
// built-in resize/scroll/mutation observers, so a RAF loop keeps the
// teleported ring glued to the node as the canvas transforms.
//
// Bounded by mount: AppOutput only renders while `isSelectOutputsMode`
// is true (see LGraphNode.vue), so the loop is scoped to the outputs-
// selection step rather than running for the lifetime of the page.
//
// Known follow-up (CR): with many output nodes visible at once, every
// instance runs its own RAF callback. Centralizing into a shared
// dispatcher (one loop driving all AppInput/AppOutput updates) would
// reduce per-frame work — out of scope for this PR.
const wrapperRef = useTemplateRef<HTMLElement>('wrapper')
const { top, left, width, height, update } = useElementBounding(wrapperRef)
useRafFn(update, { immediate: true })
Expand Down
31 changes: 31 additions & 0 deletions src/stores/appModeStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,34 @@ export const useAppModeStore = defineStore('appMode', () => {
if (index !== -1) selectedInputs.value.splice(index, 1)
}

// Toggle helpers — single entry points for selection mutations so
// callers (AppBuilder click handlers, AppInput / AppOutput overlays)
// don't manipulate the arrays directly. Keeps the surface aligned
// with the repo's command-pattern guidance and gives us a single
// place to add undo / replay later.
function toggleSelectedOutput(id: NodeId) {
const index = selectedOutputs.value.findIndex(
(k) => String(k) === String(id)
)
if (index === -1) selectedOutputs.value.push(id)
else selectedOutputs.value.splice(index, 1)
}

function removeSelectedOutput(id: NodeId) {
const index = selectedOutputs.value.findIndex(
(k) => String(k) === String(id)
)
if (index !== -1) selectedOutputs.value.splice(index, 1)
}

function toggleSelectedInput(nodeId: NodeId, widgetName: string) {
const index = selectedInputs.value.findIndex(
([id, name]) => String(id) === String(nodeId) && name === widgetName
)
if (index === -1) selectedInputs.value.push([nodeId, widgetName])
else selectedInputs.value.splice(index, 1)
}

function updateInputConfig(
nodeId: NodeId,
widgetName: string,
Expand All @@ -308,11 +336,14 @@ export const useAppModeStore = defineStore('appMode', () => {
panBy,
pruneLinearData,
removeSelectedInput,
removeSelectedOutput,
resetSelectedToWorkflow,
resetView,
selectedInputs,
selectedOutputs,
showVueNodeSwitchPopup,
toggleSelectedInput,
toggleSelectedOutput,
updateInputConfig,
viewportOffsetX,
viewportOffsetY,
Expand Down