Skip to content

Improve accessibility of dialogs #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huchenlei merged 1 commit into from
Oct 8, 2024
Merged

Improve accessibility of dialogs #1167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add aria labels to dialogs
  • Loading branch information
@christian-byrne
christian-byrne committed Oct 8, 2024
commit b987a79cd31e280f52c369d1e2b4a4bee1679392
6 changes: 5 additions & 1 deletion src/components/dialog/GlobalDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@
@maximize="onMaximize"
@unmaximize="onUnmaximize"
:pt="{ header: 'pb-0' }"
:aria-labelledby="headerId"
>
<template #header>
<component
v-if="dialogStore.headerComponent"
:is="dialogStore.headerComponent"
:id="headerId"
/>
<h3 v-else>{{ dialogStore.title || ' ' }}</h3>
<h3 v-else :id="headerId">{{ dialogStore.title || ' ' }}</h3>
</template>

<component :is="dialogStore.component" v-bind="contentProps" />
Expand Down Expand Up @@ -48,4 +50,6 @@ const contentProps = computed(() => ({
...dialogStore.props,
maximized: maximized.value
}))

const headerId = `dialog-${Math.random().toString(36).substr(2, 9)}`
</script>