Make LGraphCanvas shallowReactive #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Seems like the DOM Widget's pointerEvent is broken by this PR. When dragging a node over a DOM widget, the DOM widget is capturing the pointer event, resulting canvas losing point event tracking. |
huchenlei
force-pushed
the
shallow_canvas
branch
from
a8f19cf to
e20493a
Compare
Contributor
Author
It turns out LGraphCanvas.options.skip_events is also used after LGraphCanvas creation. Restoring that value to false fixes the problem. |
benceruleanlu
pushed a commit
that referenced
this pull request
Aug 3, 2025
Co-authored-by: christian-byrne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
LGraphCanvasshallowReactive, i.e. only changes on root LGraphCanvas are reactive.This change allows us observing changes to various LGraphCanvas root states without relying on LGraphCanvas emitting events.
Note
According to code search, there is no check against
instanceof LGraphCanvasin public ComfyUI repo, so replacing app.canvas with a Proxy of LGraphCanvas should not cause any immediate break on extensions.