Skip to content

Supports VHS video outputs in queue sidebar tab #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huchenlei merged 7 commits into from
Oct 8, 2024
Merged

Supports VHS video outputs in queue sidebar tab #1174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
609cf46
Properly identify gifs
huchenlei Oct 8, 2024
d6d285f
Detect VHS video
huchenlei Oct 8, 2024
4b1b6c7
Basic video support in queue
huchenlei Oct 8, 2024
63aca87
Video in lightbox
huchenlei Oct 8, 2024
95c9bd8
Preview button
huchenlei Oct 8, 2024
26be3a8
nit
huchenlei Oct 8, 2024
3e9726b
Fix vitest
huchenlei Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Properly identify gifs
  • Loading branch information
@huchenlei
huchenlei committed Oct 8, 2024
commit 609cf462876a8bee0f603720980b146043c26ead
4 changes: 1 addition & 3 deletions src/components/sidebar/tabs/queue/ResultItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<template>
<div class="result-container" ref="resultContainer">
<template
v-if="result.mediaType === 'images' || result.mediaType === 'gifs'"
>
<template v-if="result.isImage">
<ComfyImage
:src="result.url"
class="task-output-image"
Expand Down
14 changes: 13 additions & 1 deletion src/stores/queueStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ export class ResultItemImpl {
// 'audio' | 'images' | ...
mediaType: string

// VHS output specific fields
format?: string
frame_rate?: number

get url(): string {
return api.apiURL(`/view?filename=${encodeURIComponent(this.filename)}&type=${this.type}&
subfolder=${encodeURIComponent(this.subfolder || '')}`)
Expand All @@ -44,8 +48,16 @@ export class ResultItemImpl {
return `${this.url}&t=${+new Date()}`
}

get isGif(): boolean {
return this.filename.endsWith('.gif')
}

get isImage(): boolean {
return this.mediaType === 'images' || this.isGif
}

get supportsPreview(): boolean {
return ['images', 'gifs'].includes(this.mediaType)
return this.isImage
}
}

Expand Down