[Phase A · Foundation] ext-api/i-foundation — declarations + service rename + scope registry#12102
Draft
christian-byrne wants to merge 3 commits intoecs-vue-hoisted-client-state-hook-apifrom
Draft
[Phase A · Foundation] ext-api/i-foundation — declarations + service rename + scope registry#12102christian-byrne wants to merge 3 commits intoecs-vue-hoisted-client-state-hook-apifrom
christian-byrne wants to merge 3 commits intoecs-vue-hoisted-client-state-hook-apifrom
Conversation
added 3 commits
May 8, 2026 21:33
- src/extension-api/{index,lifecycle,node,widget}.ts polish (D5/D6/D7/D10)
- docs/architecture/extension-api-v2/names-appendix.md (DOC1.E6)
- AGENTS.md: cross-repo ownership note
Foundation step 1/3 of ext-api/i-foundation.
… (MIG1.E5) - src/services/extension-api-service.ts (canonical name; replaces extensionV2Service.ts) - src/scripts/app.ts: invoke v2 lifecycle alongside v1 at init+setup - src/services/extensionService.ts: invokeV2AppExtensions helper - src/types/extensionV2.ts: NodeEntityId/WidgetEntityId surface - src/extensions/core/index.ts: register v2 sample extensions - *.v2.ts samples: align to refreshed surface Foundation step 2/3 of ext-api/i-foundation.
- src/world/: ECS World skeleton (entities, components, NodeEntityId) - src/services/__tests__/scope-registry.test.ts: registry semantics per D10 (lifecycle context+ordering) and D12 (clone-on-copy) Foundation step 3/3 of ext-api/i-foundation. Coworker fork point: child PRs i-tf and i-ext stack on top of this branch.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ❌ FailedDetails⏰ Completed at: 05/09/2026, 04:43:06 AM UTC Links
|
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
|
📦 Bundle Size
⚡ Performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack root for Phase A child PRs. Coworkers converting core extensions should branch off this branch.
Stacks on: #12101 (Phase A base — research bundle + first-pass surface)
Three foundation commits (in order)
refactor(extension-api): polish public declaration files (D5/D6/D7/D10)—src/extension-api/{index,lifecycle,node,widget}.ts, names appendix (DOC1.E6), AGENTS.mdfeat(extension-api): rename to extension-api-service.ts + boot wiring (MIG1.E5)— canonicalextension-api-service.ts, app boot wiring, sample*.v2.tsextensions aligned to refreshed surfacefeat(extension-api): scope registry + ECS world skeleton (I-SR.2)—src/world/(entities/components/NodeEntityId),scope-registry.test.tsper D10 + D12What stacks on this
Known minor
The deletion of the old
src/services/extensionV2Service.tsended up in the i-tf child PR rather than alongside the rename here. Final merged state is correct; flagging for reviewer awareness.Refs
D5 events typing · D6 parallel paths · D7 widget shape · D10 lifecycle · D12 scope clone-on-copy · MIG1.E4/E5 boot wiring
Draft for review collaboration via inline comments.
┆Issue is synchronized with this Notion page by Unito