[Phase A · Sidecar] ext-api/i-pkg — @comfyorg/extension-api npm package + docgen + CI#12103
Draft
christian-byrne wants to merge 1 commit intoecs-vue-hoisted-client-state-hook-apifrom
Draft
[Phase A · Sidecar] ext-api/i-pkg — @comfyorg/extension-api npm package + docgen + CI#12103christian-byrne wants to merge 1 commit intoecs-vue-hoisted-client-state-hook-apifrom
christian-byrne wants to merge 1 commit intoecs-vue-hoisted-client-state-hook-apifrom
Conversation
…(PKG3/4/5)
- packages/extension-api/: @comfyorg/extension-api npm package wrapper
(src/, package.json, README.md, tsconfig{,.build,.docs}.json,
typedoc.json, scripts/build-docs.ts, .npmignore, .gitignore)
- .github/workflows/extension-api-typecheck.yml (PKG4.D3)
- .github/workflows/extension-api-publish.yml (PKG4.D4)
- scripts/generate-docs.sh (PKG5.D6)
- pnpm-lock.yaml: workspace dependency for new package
Sidecar: independent of i-foundation; stacks directly on PR #2.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
|
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
|
📦 Bundle Size
⚡ Performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidecar. Independent of i-foundation; stacks directly on #12101. Can land before or after i-foundation.
What's in
packages/extension-api/—@comfyorg/extension-api0.1.0 npm package wrapper aroundsrc/extension-api/declarationspackage.json,README.md,tsconfig{,.build,.docs}.jsontypedoc.json+scripts/build-docs.ts(TypeDoc → Mintlify MDX).npmignore,.gitignore.github/workflows/extension-api-typecheck.yml(PKG4.D3) — path-filtered typecheck + smoke.github/workflows/extension-api-publish.yml(PKG4.D4) — tag-triggerednpm publish --provenancescripts/generate-docs.sh(PKG5.D6) — thin wrapper overpnpm --filter @comfyorg/extension-api docs:buildpnpm-lock.yaml— workspace dep for new packagePending follow-up
PKG6 (separate PR on
Comfy-Org/docs) — wire generated MDX into docs.comfy.org.Draft for review collaboration via inline comments.
┆Issue is synchronized with this Notion page by Unito