[Phase A · Child] ext-api/i-ext — three new core extension conversions (I-EXT)#12105
Draft
christian-byrne wants to merge 1 commit intoext-api/i-foundationfrom
Draft
[Phase A · Child] ext-api/i-ext — three new core extension conversions (I-EXT)#12105christian-byrne wants to merge 1 commit intoext-api/i-foundationfrom
christian-byrne wants to merge 1 commit intoext-api/i-foundationfrom
Conversation
- src/extensions/core/noteNode.v2.ts - src/extensions/core/rerouteNode.v2.ts - src/extensions/core/slotDefaults.v2.ts These prove the v2 surface against more complex core extensions: noteNode (display-only), rerouteNode (link manipulation), slotDefaults (registration-time hooks). Stacks on ext-api/i-foundation. Coworkers (Simon/Austin) should branch off i-foundation in the same way to convert their target extensions.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ❌ FailedDetails⏰ Completed at: 05/09/2026, 04:43:04 AM UTC Links
|
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
|
📦 Bundle Size
⚡ Performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on: ext-api/i-foundation
Sibling: ext-api/i-tf
What's in
src/extensions/core/noteNode.v2.ts— display-only extensionsrc/extensions/core/rerouteNode.v2.ts— link manipulation extensionsrc/extensions/core/slotDefaults.v2.ts— registration-time hook extensionThese prove the v2 surface against three different shapes of core extension complexity.
Why this PR exists
Coworkers (Simon/Austin) should branch off ext-api/i-foundation in the same way to convert their target extensions. This PR is the worked example for that pattern.
Refs
I-EXT.3 · D6 hybrid accessor/method rule · D7 widget shape and persistence
Draft for review collaboration via inline comments.
┆Issue is synchronized with this Notion page by Unito