Skip to content

Enable ts-strict for dialogStore.ts #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huchenlei merged 1 commit into from
Oct 12, 2024
Merged

Enable ts-strict for dialogStore.ts #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Enable ts-strict for dialogStore.ts
  • Loading branch information
@huchenlei
huchenlei committed Oct 12, 2024
commit d1e445a8d661bd722eef929e401f51ad75469fc2
3 changes: 1 addition & 2 deletions src/stores/dialogStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// @ts-strict-ignore
// We should consider moving to https://primevue.org/dynamicdialog/ once everything is in Vue.
// Currently we need to bridge between legacy app code and Vue app with a Pinia store.

Expand Down Expand Up @@ -41,7 +40,7 @@ export const useDialogStore = defineStore('dialog', {
}) {
this.isVisible = true
nextTick(() => {
this.title = options.title
this.title = options.title ?? ''
this.headerComponent = options.headerComponent
? markRaw(options.headerComponent)
: null
Expand Down