Update template translation #4396
Conversation
comfyui-wiki
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
|
@comfyui-wiki In the code, we normalize the translation keys. That includes converting dots to underscores. So, if any template filename has dots in it, we have to convert to underscores when adding them to the translation files. I should have mentioned that in the README.md of Comfy-Org/workflow_templates. |
- Accept HEAD version (720e0a9) for all locale files - Restore Comfy_Notification_ShowVersionUpdates setting in settings.json - Ignore GitHub Action's alphabetical reorganization - Keep original template structure intact
|
Just about to add the zh-TW translation of templates and found that the GitHub Action had already finished it. 👍 |
All the template translations should now display normally.
|
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
So far I have been using "LoRA" instead of "Lora". I think "LoRA" is the standard ML terminology (Low Rank Adaption ...). WDYT?
…/Comfy-Org/ComfyUI_frontend into update-the-templates-translation
|
I see why the check failed now. The original default template's description was inconsistent with others, so I updated the text. 
Both failed checks are for the same reason. |
christian-byrne
added
the
New Browser Test Expectations
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Co-authored-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
Update all the template translations.
┆Issue is synchronized with this Notion page by Unito