Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary getter/setters.
  • Loading branch information
guill committed Jul 15, 2025
commit 0d4889f97a3daaec8f7c3440ca434083c6889f35
11 changes: 0 additions & 11 deletions src/scripts/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,17 +250,6 @@ export class ComfyApi extends EventTarget {
*/
serverFeatureFlags: Record<string, any> = {}

/**
* Alias for serverFeatureFlags for test compatibility.
*/
get feature_flags() {
return this.serverFeatureFlags
}

set feature_flags(value: Record<string, any>) {
this.serverFeatureFlags = value
}

/**
* The auth token for the comfy org account if the user is logged in.
* This is only used for {@link queuePrompt} now. It is not directly
Expand Down
12 changes: 6 additions & 6 deletions tests-ui/tests/api.featureFlags.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('API Feature Flags', () => {
global.WebSocket = vi.fn().mockImplementation(() => mockWebSocket) as any

// Reset API state
api.feature_flags = {}
api.serverFeatureFlags = {}

// Mock getClientFeatureFlags to return test feature flags
vi.spyOn(api, 'getClientFeatureFlags').mockReturnValue({
Expand Down Expand Up @@ -91,7 +91,7 @@ describe('API Feature Flags', () => {
await initPromise

// Check that server features were stored
expect(api.feature_flags).toEqual({
expect(api.serverFeatureFlags).toEqual({
supports_preview_metadata: true,
async_execution: true,
supported_formats: ['webp', 'jpeg', 'png'],
Expand Down Expand Up @@ -133,14 +133,14 @@ describe('API Feature Flags', () => {
await initPromise

// Server features should remain empty
expect(api.feature_flags).toEqual({})
expect(api.serverFeatureFlags).toEqual({})
})
})

describe('Feature checking methods', () => {
beforeEach(() => {
// Set up some test features
api.feature_flags = {
api.serverFeatureFlags = {
supports_preview_metadata: true,
async_execution: false,
capabilities: ['isolated_nodes', 'dynamic_models']
Expand Down Expand Up @@ -197,11 +197,11 @@ describe('API Feature Flags', () => {
describe('Integration with preview messages', () => {
it('should affect preview message handling based on feature support', () => {
// Test with metadata support
api.feature_flags = { supports_preview_metadata: true }
api.serverFeatureFlags = { supports_preview_metadata: true }
expect(api.serverSupportsFeature('supports_preview_metadata')).toBe(true)

// Test without metadata support
api.feature_flags = {}
api.serverFeatureFlags = {}
expect(api.serverSupportsFeature('supports_preview_metadata')).toBe(false)
})
})
Expand Down