Extract selection filtering logic to useSelectedLiteGraphItems composable and don't show toolbox when selecting Reroutes #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tems composable - Create new composable to handle filtering of selected LiteGraph items - Move Reroute filtering logic from SelectionOverlay to the composable - Add comprehensive unit tests for the new composable - Refactor SelectionOverlay to use the new composable This improves code organization by extracting reusable selection logic that can be shared across components.
|
The original implementation used computed properties that accessed the store's selectedItems array, but the canvas maintains its own selectedItems Set that needs to be accessed dynamically. Changed to use methods that directly access the canvas selectedItems each time they're called. This fixes the selection overlay to properly update when items are selected.
This composable deals with canvas rendering/selection visualization, not the graph data model, so it belongs in composables/canvas/ instead of composables/graph/.
christian-byrne
changed the title
christian-byrne
added
the
needs-backport
Merged
christian-byrne
added a commit
that referenced
this pull request
Aug 4, 2025
…able and don't show toolbox when selecting Reroutes (#4634)
christian-byrne
added a commit
that referenced
this pull request
Aug 4, 2025
…able and don't show toolbox when selecting Reroutes (#4634)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the selection filtering logic from
SelectionOverlay.vueinto a reusable composableuseSelectedLiteGraphItems. This improves code organization and makes the selection filtering logic available for other components. It also makes the functions easier to test.Changes
useSelectedLiteGraphItemscomposable that filters out Reroute nodes from selectionsSelectionOverlay.vueto use the new composableResolves #4623.
┆Issue is synchronized with this Notion page by Unito