Skip to content

[fix] Adjust performance test timing constraints for CI environments #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christian-byrne wants to merge 1 commit into from
Closed

[fix] Adjust performance test timing constraints for CI environments #4845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions tests-ui/tests/performance/spatialIndexPerformance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import { beforeEach, describe, expect, it } from 'vitest'
import { useSpatialIndex } from '@/composables/graph/useSpatialIndex'
import type { Bounds } from '@/utils/spatial/QuadTree'

// CI environments may have slower performance, so we use a multiplier for timing constraints
const CI_MULTIPLIER = process.env.CI ? 3 : 1

describe('Spatial Index Performance', () => {
let spatialIndex: ReturnType<typeof useSpatialIndex>

Expand Down Expand Up @@ -35,8 +38,8 @@ describe('Spatial Index Performance', () => {

const insertTime = performance.now() - startTime

// Should insert 1000 nodes in under 100ms
expect(insertTime).toBeLessThan(100)
// Should insert 1000 nodes in under 100ms (300ms in CI)
expect(insertTime).toBeLessThan(100 * CI_MULTIPLIER)
expect(spatialIndex.metrics.value.totalNodes).toBe(1000)
})

Expand Down Expand Up @@ -78,9 +81,9 @@ describe('Spatial Index Performance', () => {
const totalQueryTime = performance.now() - startTime
const avgQueryTime = totalQueryTime / queryCount

// Each query should take less than 2ms on average
expect(avgQueryTime).toBeLessThan(2)
expect(totalQueryTime).toBeLessThan(100) // 100 queries in under 100ms
// Each query should take less than 2ms on average (6ms in CI)
expect(avgQueryTime).toBeLessThan(2 * CI_MULTIPLIER)
expect(totalQueryTime).toBeLessThan(100 * CI_MULTIPLIER) // 100 queries in under 100ms (300ms in CI)
})

it('should demonstrate performance advantage over linear search', () => {
Expand Down Expand Up @@ -191,7 +194,7 @@ describe('Spatial Index Performance', () => {
const avgFrameTime = updateTime / updateCount

// Should maintain 60fps (16.67ms per frame) with 20 node updates per frame
expect(avgFrameTime).toBeLessThan(8) // Conservative target: 8ms per frame
expect(avgFrameTime).toBeLessThan(8 * CI_MULTIPLIER) // Conservative target: 8ms per frame (24ms in CI)
})

it('should handle node additions and removals efficiently', () => {
Expand Down Expand Up @@ -223,7 +226,7 @@ describe('Spatial Index Performance', () => {
const totalTime = performance.now() - startTime

// All operations should complete quickly
expect(totalTime).toBeLessThan(50)
expect(totalTime).toBeLessThan(50 * CI_MULTIPLIER)
expect(spatialIndex.metrics.value.totalNodes).toBe(100) // 50 remaining + 50 new
})
})
Expand Down Expand Up @@ -267,7 +270,7 @@ describe('Spatial Index Performance', () => {

// All query times should be reasonable
queryTimes.forEach((time) => {
expect(time).toBeLessThan(5) // Each query under 5ms
expect(time).toBeLessThan(5 * CI_MULTIPLIER) // Each query under 5ms (15ms in CI)
})
})

Expand Down Expand Up @@ -313,7 +316,7 @@ describe('Spatial Index Performance', () => {
}
const queryTime = performance.now() - startTime

expect(queryTime).toBeLessThan(20) // 20 queries in under 20ms
expect(queryTime).toBeLessThan(20 * CI_MULTIPLIER) // 20 queries in under 20ms (60ms in CI)
})
})

Expand Down Expand Up @@ -386,9 +389,9 @@ describe('Spatial Index Performance', () => {
const avgQueryTime = panDuration / (panPositions.length * 10)

// Performance expectations for realistic workflows
expect(setupDuration).toBeLessThan(30) // Setup 155 nodes in under 30ms
expect(avgQueryTime).toBeLessThan(1.5) // Average query under 1.5ms
expect(panDuration).toBeLessThan(50) // All panning queries under 50ms
expect(setupDuration).toBeLessThan(30 * CI_MULTIPLIER) // Setup 155 nodes in under 30ms (90ms in CI)
expect(avgQueryTime).toBeLessThan(1.5 * CI_MULTIPLIER) // Average query under 1.5ms (4.5ms in CI)
expect(panDuration).toBeLessThan(50 * CI_MULTIPLIER) // All panning queries under 50ms (150ms in CI)

// Should have reasonable culling efficiency
const totalNodes = allNodes.length
Expand Down
37 changes: 20 additions & 17 deletions tests-ui/tests/performance/transformPerformance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { beforeEach, describe, expect, it } from 'vitest'

import { useTransformState } from '@/composables/element/useTransformState'

// CI environments may have slower performance, so we use a multiplier for timing constraints
const CI_MULTIPLIER = process.env.CI ? 3 : 1

// Mock canvas context for testing
const createMockCanvasContext = () => ({
ds: {
Expand Down Expand Up @@ -47,8 +50,8 @@ describe('Transform Performance', () => {
const screenToCanvasTime = performance.now() - screenToCanvasStart

// Performance expectations
expect(canvasToScreenTime).toBeLessThan(20) // 10k conversions in under 20ms
expect(screenToCanvasTime).toBeLessThan(20) // 10k conversions in under 20ms
expect(canvasToScreenTime).toBeLessThan(20 * CI_MULTIPLIER) // 10k conversions in under 20ms (60ms in CI)
expect(screenToCanvasTime).toBeLessThan(20 * CI_MULTIPLIER) // 10k conversions in under 20ms (60ms in CI)

// Verify accuracy of round-trip conversion
const maxError = points.reduce((max, original, i) => {
Expand Down Expand Up @@ -90,8 +93,8 @@ describe('Transform Performance', () => {
const minTime = Math.min(...performanceResults)
const variance = (maxTime - minTime) / minTime

expect(maxTime).toBeLessThan(20) // All zoom levels under 20ms
expect(variance).toBeLessThan(3.0) // Less than 300% variance between zoom levels
expect(maxTime).toBeLessThan(20 * CI_MULTIPLIER) // All zoom levels under 20ms (60ms in CI)
expect(variance).toBeLessThan(3.0 * CI_MULTIPLIER) // Less than 300% variance between zoom levels (900% in CI)
})

it('should handle extreme coordinate values efficiently', () => {
Expand Down Expand Up @@ -124,7 +127,7 @@ describe('Transform Performance', () => {

const duration = performance.now() - startTime

expect(duration).toBeLessThan(5) // Should handle extremes efficiently
expect(duration).toBeLessThan(5 * CI_MULTIPLIER) // Should handle extremes efficiently (15ms in CI)
expect(
Number.isFinite(transformState.canvasToScreen(extremePoints[0]).x)
).toBe(true)
Expand Down Expand Up @@ -171,7 +174,7 @@ describe('Transform Performance', () => {

const cullTime = performance.now() - startTime

expect(cullTime).toBeLessThan(10) // 1000 nodes culled in under 10ms
expect(cullTime).toBeLessThan(10 * CI_MULTIPLIER) // 1000 nodes culled in under 10ms (30ms in CI)
expect(visibleNodes.length).toBeLessThan(nodeCount) // Some culling should occur
expect(visibleNodes.length).toBeGreaterThanOrEqual(0) // Sanity check
})
Expand Down Expand Up @@ -214,7 +217,7 @@ describe('Transform Performance', () => {

// All culling operations should be very fast
timings.forEach((time) => {
expect(time).toBeLessThan(0.1) // Individual culling under 0.1ms
expect(time).toBeLessThan(0.1 * CI_MULTIPLIER) // Individual culling under 0.1ms (0.3ms in CI)
})

// Verify adaptive behavior (margins should work as expected)
Expand Down Expand Up @@ -250,7 +253,7 @@ describe('Transform Performance', () => {
)
const cullTime = performance.now() - startTime

expect(cullTime).toBeLessThan(0.1) // Size culling under 0.1ms
expect(cullTime).toBeLessThan(0.1 * CI_MULTIPLIER) // Size culling under 0.1ms (0.3ms in CI)

// At 0.01 zoom, nodes need to be 400+ pixels to show as 4+ screen pixels
const screenSize = Math.max(size[0], size[1]) * 0.01
Expand Down Expand Up @@ -281,7 +284,7 @@ describe('Transform Performance', () => {

const syncTime = performance.now() - startTime

expect(syncTime).toBeLessThan(15) // 1000 syncs in under 15ms
expect(syncTime).toBeLessThan(15 * CI_MULTIPLIER) // 1000 syncs in under 15ms (45ms in CI)

// Verify final state is correct
const lastUpdate = transformUpdates[transformUpdates.length - 1]
Expand Down Expand Up @@ -312,7 +315,7 @@ describe('Transform Performance', () => {

const accessTime = performance.now() - startTime

expect(accessTime).toBeLessThan(200) // 10k style accesses in under 200ms
expect(accessTime).toBeLessThan(200 * CI_MULTIPLIER) // 10k style accesses in under 200ms (600ms in CI)
})
})

Expand Down Expand Up @@ -340,7 +343,7 @@ describe('Transform Performance', () => {

const calcTime = performance.now() - startTime

expect(calcTime).toBeLessThan(15) // 1000 bounds calculations in under 15ms
expect(calcTime).toBeLessThan(15 * CI_MULTIPLIER) // 1000 bounds calculations in under 15ms (45ms in CI)
expect(bounds).toHaveLength(nodeCount)

// Verify bounds are reasonable
Expand Down Expand Up @@ -378,7 +381,7 @@ describe('Transform Performance', () => {

const calcTime = performance.now() - startTime

expect(calcTime).toBeLessThan(5) // All viewport calculations in under 5ms
expect(calcTime).toBeLessThan(5 * CI_MULTIPLIER) // All viewport calculations in under 5ms (15ms in CI)
expect(allBounds).toHaveLength(combinations.length)

// Verify bounds are reasonable
Expand Down Expand Up @@ -426,14 +429,14 @@ describe('Transform Performance', () => {
frames.push(frameTime)

// Each frame should be well under 16.67ms for 60fps
expect(frameTime).toBeLessThan(1) // Conservative: under 1ms per frame
expect(frameTime).toBeLessThan(1 * CI_MULTIPLIER) // Conservative: under 1ms per frame (3ms in CI)
}

const totalTime = frames.reduce((sum, time) => sum + time, 0)
const avgFrameTime = totalTime / frameCount

expect(avgFrameTime).toBeLessThan(0.5) // Average frame time under 0.5ms
expect(totalTime).toBeLessThan(60) // Total panning overhead under 60ms
expect(avgFrameTime).toBeLessThan(0.5 * CI_MULTIPLIER) // Average frame time under 0.5ms (1.5ms in CI)
expect(totalTime).toBeLessThan(60 * CI_MULTIPLIER) // Total panning overhead under 60ms (180ms in CI)
})

it('should handle zoom performance with viewport updates', () => {
Expand Down Expand Up @@ -472,8 +475,8 @@ describe('Transform Performance', () => {
const avgZoomTime =
zoomTimes.reduce((sum, time) => sum + time, 0) / zoomSteps

expect(maxZoomTime).toBeLessThan(2) // No zoom step over 2ms
expect(avgZoomTime).toBeLessThan(1) // Average zoom step under 1ms
expect(maxZoomTime).toBeLessThan(2 * CI_MULTIPLIER) // No zoom step over 2ms (6ms in CI)
expect(avgZoomTime).toBeLessThan(1 * CI_MULTIPLIER) // Average zoom step under 1ms (3ms in CI)
})
})
})
Loading