Skip to content

[ci] Optimize ESLint performance with caching and generated file excl… #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benceruleanlu merged 4 commits into from
Aug 12, 2025
Merged

[ci] Optimize ESLint performance with caching and generated file excl… #4926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbdef50
[ci] Optimize ESLint performance with caching and generated file excl…
christian-byrne Aug 11, 2025
8852563
ci: Add linting step for generated API types
christian-byrne Aug 11, 2025
a6691aa
ci: Add auto-fix linting step for generated API types
christian-byrne Aug 11, 2025
b4788d7
[ci] Add lint:no-cache npm script and update workflows
christian-byrne Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: Add linting step for generated API types 
- Add ESLint validation to registry and manager type generation workflows
- Ensures generated files meet code standards even though they're ignored in regular lint runs
- Uses --no-ignore flag to lint specific files despite ESLint ignore patterns

Co-authored-by: Qwen-Coder <[email protected]>
  • Loading branch information
@christian-byrne @qwencoder
christian-byrne and qwencoder committed Aug 12, 2025
commit 8852563f40c9d027feddedb99d479df746979d65
5 changes: 5 additions & 0 deletions .github/workflows/update-manager-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ jobs:
exit 1
fi

- name: Lint generated types
run: |
echo "Linting generated ComfyUI-Manager API types..."
npx eslint --no-ignore ./src/types/generatedManagerTypes.ts

- name: Check for changes
id: check-changes
run: |
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/update-registry-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ jobs:
exit 1
fi

- name: Lint generated types
run: |
echo "Linting generated Comfy Registry API types..."
npx eslint --no-ignore ./src/types/comfyRegistryTypes.ts

- name: Check for changes
id: check-changes
run: |
Expand Down