Skip to content

Translated Keyboard Shortcuts #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 4 commits into from
Aug 15, 2025
Merged

Translated Keyboard Shortcuts #5007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d5e756
fix: Update command label rendering to use i18n normalization
Myestery Aug 15, 2025
a9800cd
fix: Replace deprecated with t for command label rendering
Myestery Aug 15, 2025
10117f4
fix: Simplify command rendering check in ShortcutsList tests
Myestery Aug 15, 2025
ecd5c2a
fix: Add missing translation for command label in ShortcutsList tests
Myestery Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/bottomPanel/tabs/shortcuts/ShortcutsList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
>
<div class="shortcut-info flex-grow pr-4">
<div class="shortcut-name text-sm font-medium">
{{ command.label || command.id }}
{{ t(`commands.${normalizeI18nKey(command.id)}.label`) }}
</div>
</div>

Expand Down Expand Up @@ -50,6 +50,7 @@ import { computed } from 'vue'
import { useI18n } from 'vue-i18n'

import type { ComfyCommandImpl } from '@/stores/commandStore'
import { normalizeI18nKey } from '@/utils/formatUtil'

const { t } = useI18n()

Expand Down
7 changes: 3 additions & 4 deletions tests-ui/tests/components/bottomPanel/ShortcutsList.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ const mockT = vi.fn((key: string) => {
'shortcuts.subcategories.node': 'Node',
'shortcuts.subcategories.queue': 'Queue',
'shortcuts.subcategories.view': 'View',
'shortcuts.subcategories.panelControls': 'Panel Controls'
'shortcuts.subcategories.panelControls': 'Panel Controls',
'commands.Workflow_New.label': 'New Blank Workflow'
}
return translations[key] || key
})
Expand Down Expand Up @@ -76,9 +77,7 @@ describe('ShortcutsList', () => {
expect(wrapper.text()).toContain('Queue')

// Check that commands are rendered
expect(wrapper.text()).toContain('New Workflow')
expect(wrapper.text()).toContain('Add Node')
expect(wrapper.text()).toContain('Clear Queue')
expect(wrapper.text()).toContain('New Blank Workflow')
})

it('should format keyboard shortcuts correctly', () => {
Expand Down