Skip to content

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Aug 15, 2025

Backport of #5018 to core/1.25

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…cking (#5018)

- Replace single callback storage with Map using graph UUIDs as keys
- Fix minimap not updating when navigating between subgraphs
- Add proper cleanup and error handling for callback management
- Switch from app.canvas.graph to reactive workflowStore.activeSubgraph
- Prevent callback wrapping recursion by tracking setup state per graph
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner August 15, 2025 20:35
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 15, 2025
@github-actions
Copy link

github-actions bot commented Aug 15, 2025

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

@christian-byrne christian-byrne merged commit 30009e2 into core/1.25 Aug 15, 2025
15 checks passed
@christian-byrne christian-byrne deleted the backport-5018-to-1.25 branch August 15, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants