Skip to content

Conversation

@ssidharth010
Copy link
Contributor

@ssidharth010 ssidharth010 commented Aug 17, 2025

Summary

Feature: #3870

Changes

So as mentioned in the ticket, I added a button that opens a menu listing all available workflows. The currently active workflow is displayed with a check icon.

Review Focus

Will need to verify the design. Currently i have just added a check icon for active workflow.

Screenshots (if applicable)

image

┆Issue is synchronized with this Notion page by Unito

@github-actions
Copy link

github-actions bot commented Aug 17, 2025

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

@christian-byrne christian-byrne added the Design Used to request Product feedback on design decisions label Aug 19, 2025
Copy link

@PabloWiedemann PabloWiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Can we add it to the right side of that bar? This is a more common placing of this feature

Screenshot 2025-08-18 at 7 59 48 PM

@snomiao
Copy link
Member

snomiao commented Aug 21, 2025

  • Chromatic comment should be safe to fail

@snomiao snomiao force-pushed the feat/dropdown-list-addditional-tab branch from 3e721cf to 6c3dc1b Compare August 21, 2025 06:34
@snomiao
Copy link
Member

snomiao commented Aug 21, 2025

*clicked update branch to see if playwright also fail to comment

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well and looks good.

2025-08-25.11-29-56_processed_20250825_113058.mp4

@christian-byrne
Copy link
Contributor

christian-byrne commented Aug 25, 2025

@ssidharth010 only issue I see is that the left/right arrows don't seem to do anything. What is the intended behavior? #5203

@christian-byrne
Copy link
Contributor

christian-byrne commented Aug 25, 2025

Actually, it seems the arrows were not added in this PR and were already broken. #5203

@christian-byrne
Copy link
Contributor

christian-byrne commented Aug 25, 2025

Test failures are unrelated to this PR -- still updating new CI workflows to work on a fork cc @snomiao

@christian-byrne christian-byrne force-pushed the feat/dropdown-list-addditional-tab branch from 570cfe2 to 8c4d805 Compare August 26, 2025 16:29
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding this.

@christian-byrne christian-byrne merged commit 74b61ec into Comfy-Org:main Aug 26, 2025
15 checks passed
@christian-byrne christian-byrne mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:topbar-menu Design Used to request Product feedback on design decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants