Skip to content

fix: Initialize Vue node manager when first node is added to empty graph #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 2 commits into from
Aug 19, 2025
Merged

fix: Initialize Vue node manager when first node is added to empty graph #5086

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
555d43c
fix: Initialize Vue node manager when first node is added to empty graph
christian-byrne Aug 18, 2025
ef1432d
fix: Add TODO comment for reactive graph mutations observer
christian-byrne Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/components/graph/GraphCanvas.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,32 @@ onMounted(async () => {

comfyAppReady.value = true

// Set up a one-time listener for when the first node is added
// This handles the case where Vue nodes are enabled but the graph starts empty
// TODO: Replace this with a reactive graph mutations observer when available
if (
transformPaneEnabled.value &&
comfyApp.graph &&
!nodeManager &&
comfyApp.graph._nodes.length === 0
) {
const originalOnNodeAdded = comfyApp.graph.onNodeAdded
comfyApp.graph.onNodeAdded = function (node: any) {
Comment on lines +764 to +765
Copy link
Contributor Author

@christian-byrne christian-byrne Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace later when graph mutations are made reactive.

// Restore original handler
comfyApp.graph.onNodeAdded = originalOnNodeAdded

// Initialize node manager if needed
if (transformPaneEnabled.value && !nodeManager) {
initializeNodeManager()
}

// Call original handler
if (originalOnNodeAdded) {
originalOnNodeAdded.call(this, node)
}
}
}

comfyApp.canvas.onSelectionChange = useChainCallback(
comfyApp.canvas.onSelectionChange,
() => canvasStore.updateSelectedItems()
Expand Down
Loading