Skip to content

Add support for high-resolution wheel events #5092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 17 commits into from
Aug 20, 2025
Merged

Add support for high-resolution wheel events #5092

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e68d31e
Add high res wheel event handling
webfiltered Aug 14, 2025
2335852
[Test] Add comprehensive TDD tests for device detection spec
webfiltered Aug 15, 2025
c6a7a86
Implement efficient timestamp-based device detection for mouse/trackpad
webfiltered Aug 15, 2025
14faf18
Remove magic number and unused code from device detection
webfiltered Aug 15, 2025
2c6cd13
Update old CanvasPointer tests to match new device detection behavior
webfiltered Aug 15, 2025
d2af750
Consolidate CanvasPointer tests and remove redundant test file
webfiltered Aug 16, 2025
5cfd0d9
Simplify conditional assignment with ternary operator
webfiltered Aug 19, 2025
cf623be
Remove redundant code
webfiltered Aug 19, 2025
7713de1
Simplify comments to remove redundant explanations for developers
webfiltered Aug 19, 2025
b1314fd
Refactor device detection for improved readability and maintainability
webfiltered Aug 19, 2025
fc3504c
Inline immediately-returned variable for conciseness
webfiltered Aug 19, 2025
ecddd6f
Cleanup: Remove redundant code, fix style
webfiltered Aug 20, 2025
94b2aa7
Update test expectations
webfiltered Aug 20, 2025
8a1da3f
Guard against invalid state in event comparison
webfiltered Aug 20, 2025
14da043
Fix node.js setTimeout type issue
webfiltered Aug 20, 2025
819b5b5
Remove any type from unit test
webfiltered Aug 20, 2025
f59737a
Address PR feedback
webfiltered Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Guard against invalid state in event comparison
  • Loading branch information
@webfiltered
webfiltered committed Aug 20, 2025
commit 8a1da3f89abf92818f499a85d33d7e2fe2ddc0f5
2 changes: 1 addition & 1 deletion src/lib/litegraph/src/CanvasPointer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export class CanvasPointer {
isTrackpadGesture(e: WheelEvent): boolean {
// Use the new device detection
const now = performance.now()
const timeSinceLastEvent = now - this.lastWheelEventTime
const timeSinceLastEvent = Math.max(0, now - this.lastWheelEventTime)
this.lastWheelEventTime = now

if (this.#isHighResWheelEvent(e, now)) {
Expand Down