Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/litegraph/src/litegraph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export { LGraphButton, type LGraphButtonOptions } from './LGraphButton'
export { MovingOutputLink } from './canvas/MovingOutputLink'
export { ToOutputRenderLink } from './canvas/ToOutputRenderLink'
export { ToInputFromIoNodeLink } from './canvas/ToInputFromIoNodeLink'
export type { TWidgetType, IWidgetOptions } from './types/widgets'
export type { TWidgetType, TWidgetValue, IWidgetOptions } from './types/widgets'
export {
findUsedSubgraphIds,
getDirectSubgraphIds,
Expand Down
8 changes: 7 additions & 1 deletion src/schemas/nodeDefSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,13 @@ export const zComfyNodeDef = z.object({
* Comfy Org account.
* https://docs.comfy.org/tutorials/api-nodes/overview
*/
api_node: z.boolean().optional()
api_node: z.boolean().optional(),
/**
* Specifies the order of inputs for each input category.
* Used to ensure consistent widget ordering regardless of JSON serialization.
* Keys are 'required', 'optional', etc., values are arrays of input names.
*/
input_order: z.record(z.array(z.string())).optional()
})

// `/object_info`
Expand Down
19 changes: 15 additions & 4 deletions src/services/litegraphService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import {
isVideoNode,
migrateWidgetsValues
} from '@/utils/litegraphUtil'
import { getOrderedInputSpecs } from '@/utils/nodeDefOrderingUtil'

import { useExtensionService } from './extensionService'

Expand Down Expand Up @@ -248,9 +249,14 @@ export const useLitegraphService = () => {
* @internal Add inputs to the node.
*/
#addInputs(inputs: Record<string, InputSpec>) {
for (const inputSpec of Object.values(inputs))
// Use input_order if available to ensure consistent widget ordering
const nodeDefImpl = ComfyNode.nodeData as ComfyNodeDefImpl
const orderedInputSpecs = getOrderedInputSpecs(nodeDefImpl, inputs)

// Create sockets and widgets in the determined order
for (const inputSpec of orderedInputSpecs)
this.#addInputSocket(inputSpec)
for (const inputSpec of Object.values(inputs))
for (const inputSpec of orderedInputSpecs)
this.#addInputWidget(inputSpec)
}

Expand Down Expand Up @@ -508,9 +514,14 @@ export const useLitegraphService = () => {
* @internal Add inputs to the node.
*/
#addInputs(inputs: Record<string, InputSpec>) {
for (const inputSpec of Object.values(inputs))
// Use input_order if available to ensure consistent widget ordering
const nodeDefImpl = ComfyNode.nodeData as ComfyNodeDefImpl
const orderedInputSpecs = getOrderedInputSpecs(nodeDefImpl, inputs)

// Create sockets and widgets in the determined order
for (const inputSpec of orderedInputSpecs)
this.#addInputSocket(inputSpec)
for (const inputSpec of Object.values(inputs))
for (const inputSpec of orderedInputSpecs)
this.#addInputWidget(inputSpec)
}

Expand Down
5 changes: 5 additions & 0 deletions src/stores/nodeDefStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ export class ComfyNodeDefImpl
* @deprecated Use `outputs[n].tooltip` instead
*/
readonly output_tooltips?: string[]
/**
* Order of inputs for each category (required, optional, hidden)
*/
readonly input_order?: Record<string, string[]>

// V2 fields
readonly inputs: Record<string, InputSpecV2>
Expand Down Expand Up @@ -130,6 +134,7 @@ export class ComfyNodeDefImpl
this.output_is_list = obj.output_is_list
this.output_name = obj.output_name
this.output_tooltips = obj.output_tooltips
this.input_order = obj.input_order

// Initialize V2 fields
const defV2 = transformNodeDefV1ToV2(obj)
Expand Down
108 changes: 108 additions & 0 deletions src/utils/nodeDefOrderingUtil.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
import { TWidgetValue } from '@/lib/litegraph/src/litegraph'
import type { InputSpec } from '@/schemas/nodeDef/nodeDefSchemaV2'
import type { ComfyNodeDefImpl } from '@/stores/nodeDefStore'

/**
* Gets an ordered array of InputSpec objects based on input_order.
* This is designed to work with V2 format used by litegraphService.
*
* @param nodeDefImpl - The ComfyNodeDefImpl containing both V1 and V2 formats
* @param inputs - The V2 format inputs (flat Record<string, InputSpec>)
* @returns Array of InputSpec objects in the correct order
*/
export function getOrderedInputSpecs(
nodeDefImpl: ComfyNodeDefImpl,
inputs: Record<string, InputSpec>
): InputSpec[] {
const orderedInputSpecs: InputSpec[] = []

// If no input_order, return default Object.values order
if (!nodeDefImpl.input_order) {
return Object.values(inputs)
}

// Process required inputs in specified order
if (nodeDefImpl.input_order.required) {
for (const name of nodeDefImpl.input_order.required) {
const inputSpec = inputs[name]
if (inputSpec && !inputSpec.isOptional) {
orderedInputSpecs.push(inputSpec)
}
}
}

// Process optional inputs in specified order
if (nodeDefImpl.input_order.optional) {
for (const name of nodeDefImpl.input_order.optional) {
const inputSpec = inputs[name]
if (inputSpec && inputSpec.isOptional) {
orderedInputSpecs.push(inputSpec)
}
}
}

// Add any remaining inputs not specified in input_order
const processedNames = new Set(orderedInputSpecs.map((spec) => spec.name))
for (const inputSpec of Object.values(inputs)) {
if (!processedNames.has(inputSpec.name)) {
orderedInputSpecs.push(inputSpec)
}
}

return orderedInputSpecs
}

/**
* Reorders widget values based on the input_order to match expected widget order.
* This is used when widgets were created in a different order than input_order specifies.
*
* @param widgetValues - The current widget values array
* @param currentWidgetOrder - The current order of widget names
* @param inputOrder - The desired order from input_order
* @returns Reordered widget values array
*/
export function sortWidgetValuesByInputOrder(
widgetValues: TWidgetValue[],
currentWidgetOrder: string[],
inputOrder: string[]
): TWidgetValue[] {
if (!inputOrder || inputOrder.length === 0) {
return widgetValues
}

// Create a map of widget name to value
const valueMap = new Map<string, TWidgetValue>()
currentWidgetOrder.forEach((name, index) => {
if (index < widgetValues.length) {
valueMap.set(name, widgetValues[index])
}
})

// Reorder based on input_order
const reordered: TWidgetValue[] = []
const usedNames = new Set<string>()

// First, add values in the order specified by input_order
for (const name of inputOrder) {
if (valueMap.has(name)) {
reordered.push(valueMap.get(name))
usedNames.add(name)
}
}

// Then add any remaining values not in input_order
for (const [name, value] of valueMap.entries()) {
if (!usedNames.has(name)) {
reordered.push(value)
}
}

// If there are extra values not in the map, append them
if (widgetValues.length > currentWidgetOrder.length) {
for (let i = currentWidgetOrder.length; i < widgetValues.length; i++) {
reordered.push(widgetValues[i])
}
}

return reordered
}
162 changes: 162 additions & 0 deletions tests-ui/tests/litegraph/core/LGraphNode.widgetOrder.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
import { beforeEach, describe, expect, it } from 'vitest'

import { LGraphNode } from '@/lib/litegraph/src/litegraph'
import type { ISerialisedNode } from '@/lib/litegraph/src/types/serialisation'
import { sortWidgetValuesByInputOrder } from '@/utils/nodeDefOrderingUtil'

describe('LGraphNode widget ordering', () => {
let node: LGraphNode

beforeEach(() => {
node = new LGraphNode('TestNode')
})

describe('configure with widgets_values', () => {
it('should apply widget values in correct order when widgets order matches input_order', () => {
// Create node with widgets
node.addWidget('number', 'steps', 20, null, {})
node.addWidget('number', 'seed', 0, null, {})
node.addWidget('text', 'prompt', '', null, {})

// Configure with widget values
const info: ISerialisedNode = {
id: 1,
type: 'TestNode',
pos: [0, 0],
size: [200, 100],
flags: {},
order: 0,
mode: 0,
widgets_values: [30, 12345, 'test prompt']
}

node.configure(info)

// Check widget values are applied correctly
expect(node.widgets![0].value).toBe(30) // steps
expect(node.widgets![1].value).toBe(12345) // seed
expect(node.widgets![2].value).toBe('test prompt') // prompt
})

it('should handle mismatched widget order with input_order', () => {
// Simulate widgets created in wrong order (e.g., from unordered Object.entries)
// but widgets_values is in the correct order according to input_order
node.addWidget('number', 'seed', 0, null, {})
node.addWidget('text', 'prompt', '', null, {})
node.addWidget('number', 'steps', 20, null, {})

// Widget values are in input_order: [steps, seed, prompt]
const info: ISerialisedNode = {
id: 1,
type: 'TestNode',
pos: [0, 0],
size: [200, 100],
flags: {},
order: 0,
mode: 0,
widgets_values: [30, 12345, 'test prompt']
}

// This would apply values incorrectly without proper ordering
node.configure(info)

// Without fix, values would be applied in wrong order:
// seed (widget[0]) would get 30 (should be 12345)
// prompt (widget[1]) would get 12345 (should be 'test prompt')
// steps (widget[2]) would get 'test prompt' (should be 30)

// This test demonstrates the bug - values are applied in wrong order
expect(node.widgets![0].value).toBe(30) // seed gets steps value (WRONG)
expect(node.widgets![1].value).toBe(12345) // prompt gets seed value (WRONG)
expect(node.widgets![2].value).toBe('test prompt') // steps gets prompt value (WRONG)
})

it('should skip widgets with serialize: false', () => {
node.addWidget('number', 'steps', 20, null, {})
node.addWidget('button', 'action', 'Click', null, {})
node.widgets![1].serialize = false // button should not serialize
node.addWidget('number', 'seed', 0, null, {})

const info: ISerialisedNode = {
id: 1,
type: 'TestNode',
pos: [0, 0],
size: [200, 100],
flags: {},
order: 0,
mode: 0,
widgets_values: [30, 12345] // Only serializable widgets
}

node.configure(info)

expect(node.widgets![0].value).toBe(30) // steps
expect(node.widgets![1].value).toBe('Click') // button unchanged
expect(node.widgets![2].value).toBe(12345) // seed
})
})
})

describe('sortWidgetValuesByInputOrder', () => {
it('should reorder widget values based on input_order', () => {
const inputOrder = ['steps', 'seed', 'prompt']
const currentWidgetOrder = ['seed', 'prompt', 'steps']
const widgetValues = [12345, 'test prompt', 30]

const reordered = sortWidgetValuesByInputOrder(
widgetValues,
currentWidgetOrder,
inputOrder
)

// Should reorder to match input_order: [steps, seed, prompt]
expect(reordered).toEqual([30, 12345, 'test prompt'])
})

it('should handle widgets not in input_order', () => {
const inputOrder = ['steps', 'seed']
const currentWidgetOrder = ['seed', 'prompt', 'steps', 'cfg']
const widgetValues = [12345, 'test prompt', 30, 7.5]

const reordered = sortWidgetValuesByInputOrder(
widgetValues,
currentWidgetOrder,
inputOrder
)

// Should put ordered items first, then unordered
expect(reordered).toEqual([30, 12345, 'test prompt', 7.5])
})

it('should handle empty input_order', () => {
const inputOrder: string[] = []
const currentWidgetOrder = ['seed', 'prompt', 'steps']
const widgetValues = [12345, 'test prompt', 30]

const reordered = sortWidgetValuesByInputOrder(
widgetValues,
currentWidgetOrder,
inputOrder
)

// Should return values unchanged
expect(reordered).toEqual([12345, 'test prompt', 30])
})

it('should handle mismatched array lengths', () => {
const inputOrder = ['steps', 'seed', 'prompt']
const currentWidgetOrder = ['seed', 'prompt']
const widgetValues = [12345, 'test prompt', 30] // Extra value

const reordered = sortWidgetValuesByInputOrder(
widgetValues,
currentWidgetOrder,
inputOrder
)

// Should handle gracefully, keeping extra values at the end
// Since 'steps' is not in currentWidgetOrder, it won't be reordered
// Only 'seed' and 'prompt' will be reordered based on input_order
expect(reordered).toEqual([12345, 'test prompt', 30])
})
})
Loading