Cleanup: Potpourri PR of small changes that reduce the warning noise #5128
Conversation
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/25/2025, 06:51:47 PM UTC 📊 Test Reports by Browser
🎉 Your tests are passing across all browsers! |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 08/22/2025, 10:10:38 PM UTC 📊 Build Summary
🔗 Links🎉 Your Storybook is ready for review! |
DrJKL
force-pushed
the
drjkl/warnings-fixes
branch
from
f078273 to
c84affd
Compare
DrJKL
force-pushed
the
drjkl/warnings-fixes
branch
from
3ecd9ce to
d5bbfda
Compare
DrJKL
force-pushed
the
drjkl/warnings-fixes
branch
from
d5bbfda to
cb45fe7
Compare
|
Rebasing to apply test fixes! |
christian-byrne
force-pushed
the
drjkl/warnings-fixes
branch
from
cb45fe7 to
8fbaa51
Compare
| deep: true, | ||
| extensions: ['vue'] | ||
| extensions: ['vue'], | ||
| directoryAsNamespace: true |
There was a problem hiding this comment.
I guess this would be a major change if not for the fact that we don't use uplugin-components and typically still import explicitly.
There was a problem hiding this comment.
I'm wondering if there's any cases of us not importing a component though and if there's a way to check/verify with one of our linter rules.
There was a problem hiding this comment.
If we're not using it, should we get rid of it?
There was a problem hiding this comment.
I'm not 100% positive we are not using it, there may be some locations where it's used.
There was a problem hiding this comment.
No new build errors, all the vitest tests pass, App seems to be working as expected.
If I missed something and it breaks later, I will accept the shame.
DrJKL
force-pushed
the
drjkl/warnings-fixes
branch
from
8fbaa51 to
b026a4d
Compare
Summary
Potpourri PR of small changes that reduce the warning noise
Changes
Review Focus
Let me know what other warnings you are too used to seeing that could be addressed.
┆Issue is synchronized with this Notion page by Unito