-
Notifications
You must be signed in to change notification settings - Fork 449
Decouple link and slot hit-testing out of Litegraph #5134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9228b94
[feat] TransformPane - Viewport synchronization layer for Vue nodes (…
christian-byrne b8ca5d5
Update locales [skip ci]
invalid-email-address 39d6f5c
Update locales [skip ci]
invalid-email-address 3a29a20
Add vue node feature flag (#4927)
benceruleanlu 6f07f6d
feat: Implement CRDT-based layout system for Vue nodes (#4959)
christian-byrne 7dbbb75
[chore] Extract link rendering out of LGraphCanvas (#4994)
benceruleanlu b7b9bb3
feat: Add slot registration and spatial indexing for hit detection
benceruleanlu 8206534
Revert "feat: Add slot registration and spatial indexing for hit dete…
benceruleanlu 3dd3ea4
feat: Add slot registration and spatial indexing for hit detection
benceruleanlu d7dd3a7
relocate slot update to layoutstore
benceruleanlu db287d1
Revert "relocate slot update to layoutstore"
benceruleanlu 3640366
add useSlotLayoutSync
benceruleanlu 2123795
feat: Extend Layout Store with CRDT support for links and reroutes
benceruleanlu 2a2e623
Scuffed diff, change to dirty later
benceruleanlu 612be1d
Fix reroute move desync
benceruleanlu 7f9f079
Terrible reroute fixes
benceruleanlu 023af03
Use LinkId for LinkLayout
benceruleanlu 5a8d41d
refactor: Remove unused duplicate layout type files
benceruleanlu a58162e
refactor: Extract layout source strings into LayoutSource enum
benceruleanlu afddeaa
refactor: Unify CRDT layout operations under type-safe entity bases
benceruleanlu 9d5f983
Fix initial link seeding
benceruleanlu c11dcd2
fix: Fix reroute hit detection and type consistency issues
benceruleanlu c20e2e6
Add debug logs
benceruleanlu ec9620d
Add missing reroute path
benceruleanlu 736fd35
cleanup
benceruleanlu 77b7d05
feat: Implement event-driven link layout sync
benceruleanlu a5fc834
feat: Implement DOM-based slot registration with unified position system
benceruleanlu 3b5a3d7
Remove unused files
benceruleanlu 7d7e967
Remove duplicated markdown file
benceruleanlu 350faad
Remove duplicated files and address knip concerns
benceruleanlu 745d8d7
Merge branch 'vue-nodes-migration' into bl-move-hit-detection-v2
benceruleanlu 6aac753
Remove outdated test
benceruleanlu 5771e5d
warning comment
benceruleanlu a5471aa
Update test snapshots
benceruleanlu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add debug logs
- Loading branch information
commit c20e2e6b5e109d33a645304d6502c98b68cffa87
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to delete things like slots in the
handleDeleteNode?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which handleDeleteNode?
this is the verbatim for LayoutStore that I see: