Skip to content

[fix] Correct WhatsNew popup arrow alignment with help center icon #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 4 commits into from
Aug 27, 2025
Merged

[fix] Correct WhatsNew popup arrow alignment with help center icon #5137

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f61564
[fix] Correct WhatsNew popup arrow alignment with help center icon
christian-byrne Aug 20, 2025
6cdb403
[fix] Update small sidebar arrow positioning and improve center align…
christian-byrne Aug 24, 2025
ed8abd7
[fix] Make sidebar CSS variables global for teleported components
viva-jinyi Aug 26, 2025
f14afb6
fix: icon-size should be variable
viva-jinyi Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[fix] Correct WhatsNew popup arrow alignment with help center icon 
The arrow positioning was not accounting for additional sidebar icons (terminal and shortcuts)
that were added below the help center icon, causing misalignment. Updated the calculation to
properly position the arrow relative to the help center icon's current location.

Fixes #5126
  • Loading branch information
@christian-byrne @viva-jinyi
christian-byrne authored and viva-jinyi committed Aug 27, 2025
commit 2f6156496bdba9a3e8368f2f0c323f82940352fd
6 changes: 2 additions & 4 deletions src/components/helpcenter/WhatsNewPopup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ const closePopup = async () => {
hide()
}

// Learn more handled by anchor href

// const handleCTA = async () => {
// window.open('https://docs.comfy.org/installation/update_comfyui', '_blank')
// await closePopup()
Expand Down Expand Up @@ -171,8 +169,8 @@ defineExpose({
.help-center-arrow {
position: absolute;
bottom: calc(
var(--sidebar-width, 4rem) + 0.25rem
); /* Position toward center of help center icon */
var(--sidebar-width, 4rem) * 2 + 0.25rem
); /* Position toward center of help center icon (accounting for 2 icons below) */
Copy link
Member

@viva-jinyi viva-jinyi Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.whats-new-popup-container.sidebar-left.small-sidebar .help-center-arrow The CSS further down has a higher priority, so this one doesn’t get applied first. And you also need to take the --p-button-padding-y padding value into account to find the correct position.
스크린샷 2025-08-21 오후 1 01 59

Copy link
Contributor Author

@christian-byrne christian-byrne Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help, let me fix tomorrow

transform: none;
z-index: 999;
pointer-events: none;
Expand Down