Skip to content

[tests] update selection overlay tests after canvas migration #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 7 commits into from
Aug 23, 2025
Merged

[tests] update selection overlay tests after canvas migration #5173

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f609e0c
[fix] update selection overlay tests after canvas migration
christian-byrne Aug 23, 2025
3b21620
[chore] remove unused file flagged by knip
christian-byrne Aug 23, 2025
1ce7743
[fix] adjust test expectations for canvas-based positioning
christian-byrne Aug 23, 2025
333a762
[fix] improve positioning test flexibility and revert webp skip
christian-byrne Aug 23, 2025
ee311fc
Update test expectations [skip ci]
invalid-email-address Aug 23, 2025
57bc4c2
[refactor] address review comments - use fixture locators
christian-byrne Aug 23, 2025
1e0eb2b
[refactor] use fixture canvas locator for screenshots
christian-byrne Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[refactor] use fixture canvas locator for screenshots 
Replace inline canvas locators with comfyPage.canvas fixture property
for consistency and maintainability as suggested in review.
  • Loading branch information
@christian-byrne
christian-byrne committed Aug 23, 2025
commit 1e0eb2bb0f2bce2f5ac0ff8bd4157cd8ae5b166c
8 changes: 4 additions & 4 deletions browser_tests/tests/selectionToolbox.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test.describe('Selection Toolbox', () => {
// Selection toolbox should be visible with multiple nodes selected
await expect(comfyPage.selectionToolbox).toBeVisible()
// Border is now drawn on canvas, check via screenshot
await expect(comfyPage.page.locator('canvas')).toHaveScreenshot(
await expect(comfyPage.canvas).toHaveScreenshot(
'selection-toolbox-multiple-nodes-border.png'
)
})
Expand Down Expand Up @@ -70,23 +70,23 @@ test.describe('Selection Toolbox', () => {
// Selection toolbox should be visible but without border
await expect(comfyPage.selectionToolbox).toBeVisible()
// Border is now drawn on canvas, check via screenshot
await expect(comfyPage.page.locator('canvas')).toHaveScreenshot(
await expect(comfyPage.canvas).toHaveScreenshot(
'selection-toolbox-single-node-no-border.png'
)

// Select multiple nodes
await comfyPage.selectNodes(['KSampler', 'CLIP Text Encode (Prompt)'])

// Selection border should show with multiple selections (canvas-based)
await expect(comfyPage.page.locator('canvas')).toHaveScreenshot(
await expect(comfyPage.canvas).toHaveScreenshot(
'selection-toolbox-multiple-selections-border.png'
)

// Deselect to single node
await comfyPage.selectNodes(['CLIP Text Encode (Prompt)'])

// Border should be hidden again (canvas-based)
await expect(comfyPage.page.locator('canvas')).toHaveScreenshot(
await expect(comfyPage.canvas).toHaveScreenshot(
'selection-toolbox-single-selection-no-border.png'
)
})
Expand Down
Loading