Skip to content

fix: address reviewer feedback on cache optimization PR #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snomiao merged 2 commits into from
Aug 26, 2025
Merged

fix: address reviewer feedback on cache optimization PR #5200

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ed3e1
fix: remove duplicate cache entries and fix YAML formatting
christian-byrne Aug 25, 2025
6661426
fix: add cache-dependency-path for setup-node in test-ui workflow
christian-byrne Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add cache-dependency-path for setup-node in test-ui workflow 
The test-ui workflow runs at repo root but package-lock.json is in ComfyUI_frontend/
subdirectory, causing setup-node cache to fail. Added cache-dependency-path to fix this.
  • Loading branch information
@christian-byrne
christian-byrne committed Aug 25, 2025
commit 6661426a3a84f115428b260cdae01508c8186919
1 change: 1 addition & 0 deletions .github/workflows/test-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
with:
node-version: lts/*
cache: 'npm'
cache-dependency-path: 'ComfyUI_frontend/package-lock.json'

- name: Get current time
id: current-time
Expand Down