[bugfix] Fix refresh node definitions for subgraph nodes #5222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refreshComboInNodes function was only iterating over top-level nodes, missing nodes inside subgraphs. This caused file lists and combo widget options to not update properly when new models were added, unless users created completely new nodes. Changes: - Replace graph.nodes iteration with forEachNode() for hierarchical traversal - Import forEachNode utility from graphTraversalUtil - Change early continue to early return for callback function Fixes #5196 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/27/2025, 02:48:28 AM UTC 📊 Test Reports by Browser
🎉 Your tests are passing across all browsers! |
AustinMroz
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where "Refresh Node Definitions" doesn't update combo widget options for nodes inside subgraphs.
refreshComboInNodes()function was only iterating over top-level nodes (this.graph.nodes)Changes
for (const node of this.graph.nodes)withforEachNode(this.graph, (node) => {...})forEachNodeutility from@/utils/graphTraversalUtilcontinuetoreturnfor callback function compatibilityTechnical Details
The
forEachNodeutility recursively traverses the graph hierarchy:node.subgraphpropertyTest Plan
Fixes #5196
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito