Upstream ComfyUI-Manager #5228
Closed
Upstream ComfyUI-Manager #5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ComfyUI Manager types and API schemas to support the new menu items structure and manager functionality.
Updated ComfyUI Manager service and dialog service to support the new menu items structure and API endpoints.
Updated manager queue composable, server logs composable, workflow packs composable, and manager store to support the new manager API structure and state management patterns.
Updated manager dialog components, pack cards, version selectors, and action buttons to work with the new manager API and state management structure.
Updated tests for manager queue composable, server logs composable, and manager store to work with the new API signatures and functionality.
- Fix ManagerProgressDialogContent test mock to include all required store methods - Add missing MergedNodePack, RegistryPack type definitions and isMergedNodePack type guard - Ensure all unit tests (548 passed) and component tests (174 passed) are working - Fix TypeScript compilation errors related to manager store interfaces
Update test to simulate cm-task-started events before logs events to match the actual behavior of the composable.
The test was expecting subscribeLogs(false) to be called, but this was commented out in commit 33d6447 to fix logs stopping after the first of multiple queue tasks. Updated test to reflect this temporary change.
- Add PackUpdateButton component for bulk updates - Add useUpdateAvailableNodes composable to track available updates - Integrate update all button in RegistrySearchBar - Add localization strings for update functionality - Add comprehensive tests for update functionality - Add loading state to PackActionButton
This merge restores work that was lost during a bad rebase ~2 months ago. Key restored functionality: - ComfyUI Manager service with queue/task API endpoint - Manager queue composable and WebSocket status handling - Enhanced manager dialog commands and UI labels - Manager websocket queue status enum types - Server feature flag support functions Resolves conflicts between recovery commit 730b278 and feature branch manager/menu-items-migration to combine all lost work. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
christian-byrne
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:XXL
christian-byrne
changed the title
Contributor
Author
|
Replaced by #5291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the migration of ComfyUI-Manager into the frontend as a core dependency/feature.
See details in related blog posts:
┆Issue is synchronized with this Notion page by Unito