Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[fix] Move i18n tests to separate config to avoid CI conflicts
  • Loading branch information
snomiao committed Aug 31, 2025
commit dae586533faba29fb0286615f52bca4d3a607566
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"knip": "knip --cache",
"knip:no-cache": "knip",
"locale": "lobe-i18n locale",
"collect-i18n": "nx run @comfyorg/comfyui-frontend:e2e --grep=\"collect-i18n\"",
"collect-i18n": "playwright test --config=playwright.i18n.config.ts",
"json-schema": "tsx scripts/generate-json-schema.ts",
"storybook": "nx storybook -p 6006",
"build-storybook": "storybook build"
Expand Down
11 changes: 7 additions & 4 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,23 @@ export default defineConfig({
name: 'chromium',
use: { ...devices['Desktop Chrome'] },
timeout: 15000,
grepInvert: /@mobile/ // Run all tests except those tagged with @mobile
grepInvert: /@mobile|collect-i18n/ // Run all tests except mobile and i18n collection tests
},

{
name: 'chromium-2x',
use: { ...devices['Desktop Chrome'], deviceScaleFactor: 2 },
timeout: 15000,
grep: /@2x/ // Run all tests tagged with @2x
grep: /@2x/, // Run all tests tagged with @2x
grepInvert: /collect-i18n/ // Exclude i18n collection tests
},

{
name: 'chromium-0.5x',
use: { ...devices['Desktop Chrome'], deviceScaleFactor: 0.5 },
timeout: 15000,
grep: /@0.5x/ // Run all tests tagged with @0.5x
grep: /@0.5x/, // Run all tests tagged with @0.5x
grepInvert: /collect-i18n/ // Exclude i18n collection tests
},

// {
Expand All @@ -62,7 +64,8 @@ export default defineConfig({
{
name: 'mobile-chrome',
use: { ...devices['Pixel 5'], hasTouch: true },
grep: /@mobile/ // Run only tests tagged with @mobile
grep: /@mobile/, // Run only tests tagged with @mobile
grepInvert: /collect-i18n/ // Exclude i18n collection tests
}
// {
// name: 'Mobile Safari',
Expand Down
13 changes: 13 additions & 0 deletions playwright.i18n.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { defineConfig } from '@playwright/test'

export default defineConfig({
testDir: './scripts/i18n',
use: {
baseURL: 'http://localhost:5173',
headless: true
},
reporter: 'list',
timeout: 60000,
testMatch: /collect-i18n-.*\.ts/
// Don't use globalSetup/globalTeardown to avoid ComfyUI path dependencies
})
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import * as fs from 'fs'

import { comfyPageFixture as test } from '../../browser_tests/fixtures/ComfyPage'
import { CORE_MENU_COMMANDS } from '../../src/constants/coreMenuCommands'
import { SERVER_CONFIG_ITEMS } from '../../src/constants/serverConfig'
import type { ComfyCommandImpl } from '../../src/stores/commandStore'
import type { FormItem, SettingParams } from '../../src/types/settingTypes'
import { formatCamelCase, normalizeI18nKey } from '../../src/utils/formatUtil'
import { comfyPageFixture as test } from '../fixtures/ComfyPage'

const localePath = './src/locales/en/main.json'
const commandsPath = './src/locales/en/commands.json'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as fs from 'fs'

import { comfyPageFixture as test } from '../../browser_tests/fixtures/ComfyPage'
import { normalizeI18nKey } from '../../src/utils/formatUtil'
import { comfyPageFixture as test } from '../fixtures/ComfyPage'

const localePath = './src/locales/en/main.json'
const nodeDefsPath = './src/locales/en/nodeDefs.json'
Expand Down