knip: YOLO pass, all the unused exports enabled, YAGNI for the rest #5313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/05/2025, 05:18:29 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
DrJKL
force-pushed
the
drjkl/knip-2
branch
2 times, most recently
from
eaf815a to
aec56e0
Compare
Collaborator
|
LGTM! Some minor concern with LinkDireciton: I recall seeing a custom node ~a year ago with directional reroutes, but code search isn't turning up anything. |
Paired with @christian-byrne to allow for some special cases to remain with custom knip ignore tags.
Merged
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
…5313) * knip: Enable unusedBinaries, add two exceptions * knip: YOLO pass, all the unused exports enabled. Paired with @christian-byrne to allow for some special cases to remain with custom knip ignore tags. * knip: remove post-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Going for it.
Changes
Review Focus
I'm mostly putting this up to see how CI reacts.
┆Issue is synchronized with this Notion page by Unito