feat: Auto-close LoadWorkflowWarning dialog when all missing nodes are installed #5321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viva-jinyi
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:M
🎭 Playwright Test Results✅ Tests completed successfully! ⏰ Completed at: 09/10/2025, 12:04:42 PM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
previously approved these changes
Sep 4, 2025
Contributor
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
This looks safe enough. Could you add a video showing the behavior?
| // Watch for completion and close dialog | ||
| watch(allMissingNodesInstalled, (allInstalled) => { | ||
| if (allInstalled && missingNodePacks.value !== null) { |
Contributor
There was a problem hiding this comment.
Isn't missingNodePacks.value !== null implied by allMissingNodesInstalled?
Member
Author
There was a problem hiding this comment.
All missing nodes have been installed" means:
- Loading has finished + No installation in progress + Zero missing packs remaining = true
- If any condition is missing, the dialog may close at the wrong timing.
| detail: t('manager.allMissingNodesInstalled'), | ||
| life: 3000 | ||
| }) | ||
| }, 500) |
Contributor
There was a problem hiding this comment.
I feel like we don't need the timeout if we are showing a toast anyway, WDYT?
If we are using a timeout, do you think we need to:
- clear it in
unMountedor, alternatively, use https://vueuse.org/shared/useTimeout/ - add deduplication to prevent multiple queued calls
Contributor
There was a problem hiding this comment.
If the issue is a race condition with missingNodePacks changes -> missingNodePacks may not update fully until next tick, then we could just add nextTick() for now.
Member
Author
There was a problem hiding this comment.
I will use nextTick to ensure state updates are complete.
viva-jinyi
added
needs-backport
…e installed - Add computed property to check if all missing nodes are installed - Watch for completion and automatically close dialog with 500ms delay - Show success toast notification when installation completes - Add translation key for success message This improves UX by automatically dismissing the warning dialog once the user has successfully installed all missing nodes through the manager.
viva-jinyi
force-pushed
the
manager/fix/warning-dialog-dismiss
branch
from
395d05a to
4a6633c
Compare
Member
Author
screen-capture.1.webm |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Member
Author
screen-capture.webm |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…e installed (#5321) * feat: Auto-close LoadWorkflowWarning dialog when all missing nodes are installed - Add computed property to check if all missing nodes are installed - Watch for completion and automatically close dialog with 500ms delay - Show success toast notification when installation completes - Add translation key for success message This improves UX by automatically dismissing the warning dialog once the user has successfully installed all missing nodes through the manager. * fix: settimeout to nexttick * [auto-fix] Apply ESLint and Prettier fixes --------- Co-authored-by: GitHub Action <[email protected]>
Member
|
@viva-jinyi Successfully backported to #5487 |
christian-byrne
pushed a commit
that referenced
this pull request
Sep 11, 2025
…e installed (#5321) (#5487) * feat: Auto-close LoadWorkflowWarning dialog when all missing nodes are installed - Add computed property to check if all missing nodes are installed - Watch for completion and automatically close dialog with 500ms delay - Show success toast notification when installation completes - Add translation key for success message This improves UX by automatically dismissing the warning dialog once the user has successfully installed all missing nodes through the manager. * fix: settimeout to nexttick * [auto-fix] Apply ESLint and Prettier fixes --------- Co-authored-by: Jin Yi <[email protected]> Co-authored-by: GitHub Action <[email protected]>
Merged
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
…e installed (#5321) * feat: Auto-close LoadWorkflowWarning dialog when all missing nodes are installed - Add computed property to check if all missing nodes are installed - Watch for completion and automatically close dialog with 500ms delay - Show success toast notification when installation completes - Add translation key for success message This improves UX by automatically dismissing the warning dialog once the user has successfully installed all missing nodes through the manager. * fix: settimeout to nexttick * [auto-fix] Apply ESLint and Prettier fixes --------- Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically close the LoadWorkflowWarning dialog when all missing nodes have been successfully installed through the Manager.
Changes
Implementation
allMissingNodesInstalledthat checks:!isLoading)missingNodePacks.length === 0)!isInstalling)User Experience Improvements
Testing
Type of Change
┆Issue is synchronized with this Notion page by Unito