[chore] Replace npx with pnpx across the codebase #5329

snomiao · 2025-09-04T02:13:11Z

Summary

Migrated all npx commands to pnpx to align with the pnpm ecosystem
Updated all occurrences across the codebase for consistency

Changes

Package.json scripts: Updated test:browser, preinstall, and collect-i18n scripts
GitHub Actions workflows: Updated all workflow files that use npx (test-ui, i18n, update-manager-types, etc.)
Documentation: Updated browser_tests/README.md and docs/extensions/development.md
Husky pre-commit hook: Updated lint-staged and tsx commands
MCP configuration: Updated .mcp.json to use pnpx

Test Plan

CI tests pass
Local development commands work with pnpx
GitHub Actions workflows execute successfully

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

github-actions · 2025-09-04T02:13:23Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/26/2025, 07:36:47 AM UTC

📈 Summary

Total Tests: 463
Passed: 433 ✅
Failed: 0
Flaky: 1 ⚠️
Skipped: 29 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 426 / ❌ 0 / ⚠️ 1 / ⏭️ 29
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

DrJKL

👍🏻

.github/workflows/i18n-custom-nodes.yaml

.github/workflows/i18n.yaml

.husky/pre-commit

.github/workflows/i18n-custom-nodes.yaml

.github/workflows/i18n-node-defs.yaml

.github/workflows/i18n.yaml

.github/workflows/test-browser-exp.yaml

knip.config.ts

snomiao · 2025-09-23T01:59:19Z

Added reusable workflow for cached playwright browser installation, its ready for review again now :D

@DrJKL

.github/actions/setup-playwright/action.yml

DrJKL

Would you mind splitting this into two PRs, one that just does the pnpm exec / pnpm dlx and another for the Playwright composite action?

I'm very excited to have less duplication across the actions.

DrJKL · 2025-09-24T16:59:07Z

.github/actions/setup-playwright/action.yml

+  browsers:
+    description: 'Browsers to install (chromium, firefox, webkit, or "all")'
+    required: false
+    default: 'chromium'


I would start with just extracting the current behavior from the actions we're using.
We can always add features later, as we need them.

solved this in - Add Playwright composite action to reduce workflow duplication by snomiao · Pull Request #5754 · Comfy-Org/ComfyUI_frontend

.github/actions/setup-playwright/action.yml

.github/workflows/test-ui.yaml

DrJKL · 2025-09-26T06:21:21Z

Clean, I like it, but most of these should probably be pnpm exec instead of pnpm dlx, if it's a case where we've already done a pnpm install for the dep.

- Use 'pnpm exec' for dependencies that are installed (playwright, tsx, lint-staged, nx) - Use 'pnpm dlx' for packages that are run once without installation (wrangler, openapi-typescript, only-allow) - Update MCP config to use 'pnpm dlx' instead of 'pnpx -y'

- Resolved merge conflicts by taking main branch changes - Reapplied npx -> pnpm exec conversions for installed deps - Removed .mcp.json as it was deleted in main

snomiao · 2025-09-26T07:32:00Z

Clean, I like it, but most of these should probably be pnpm exec instead of pnpm dlx, if it's a case where we've already done a pnpm install for the dep.

@DrJKL Done!

already set auto-merge.

will merge if everything works fine

## Summary - Migrated all `npx` commands to `pnpx` to align with the pnpm ecosystem - Updated all occurrences across the codebase for consistency ## Changes - **Package.json scripts**: Updated test:browser, preinstall, and collect-i18n scripts - **GitHub Actions workflows**: Updated all workflow files that use npx (test-ui, i18n, update-manager-types, etc.) - **Documentation**: Updated browser_tests/README.md and docs/extensions/development.md - **Husky pre-commit hook**: Updated lint-staged and tsx commands - **MCP configuration**: Updated .mcp.json to use pnpx ## Test Plan - [ ] CI tests pass - [ ] Local development commands work with pnpx - [ ] GitHub Actions workflows execute successfully 🤖 Generated with Claude Code ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5329-chore-Replace-npx-with-pnpx-across-the-codebase-2646d73d36508127bd43d14b8364aeb1) by [Unito](https://www.unito.io)

snomiao requested a review from DrJKL September 4, 2025 21:34

snomiao self-assigned this Sep 4, 2025

snomiao marked this pull request as ready for review September 4, 2025 21:34

snomiao requested review from a team as code owners September 4, 2025 21:34

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 4, 2025

snomiao force-pushed the sno-pnpx branch from e59717c to f2a2e53 Compare September 4, 2025 21:37

DrJKL self-assigned this Sep 4, 2025

DrJKL previously approved these changes Sep 4, 2025

View reviewed changes

.github/workflows/i18n-custom-nodes.yaml Show resolved Hide resolved

.github/workflows/i18n.yaml Show resolved Hide resolved

.husky/pre-commit Show resolved Hide resolved

DrJKL requested review from Myestery and webfiltered September 4, 2025 23:40

DrJKL removed their assignment Sep 4, 2025

snomiao dismissed DrJKL’s stale review via 005b6fc September 4, 2025 23:43

snomiao requested a review from DrJKL September 6, 2025 20:08

DrJKL mentioned this pull request Sep 7, 2025

Update pre-commit hook to use pnpm exec #5412

Merged

DrJKL requested changes Sep 11, 2025

View reviewed changes

snomiao force-pushed the sno-pnpx branch from 4cae442 to add0157 Compare September 23, 2025 00:07

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 23, 2025

snomiao requested a review from DrJKL September 23, 2025 01:58

christian-byrne assigned DrJKL and unassigned snomiao Sep 23, 2025

DrJKL mentioned this pull request Sep 23, 2025

[feat] Add comprehensive caching to CICD workflows #4982

Closed

3 tasks

snomiao requested a review from christian-byrne September 24, 2025 04:39

benceruleanlu previously approved these changes Sep 24, 2025

View reviewed changes

.github/actions/setup-playwright/action.yml Outdated Show resolved Hide resolved

DrJKL requested changes Sep 24, 2025

View reviewed changes

.github/actions/setup-playwright/action.yml Outdated Show resolved Hide resolved

DrJKL requested changes Sep 24, 2025

View reviewed changes

snomiao mentioned this pull request Sep 24, 2025

Add Playwright composite action to reduce workflow duplication #5754

Merged

[chore] Replace npx with pnpx for pnpm consistency

f902ad0

snomiao dismissed benceruleanlu’s stale review via f902ad0 September 26, 2025 06:18

snomiao force-pushed the sno-pnpx branch from 958221b to f902ad0 Compare September 26, 2025 06:18

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 26, 2025

DrJKL self-requested a review September 26, 2025 06:22

DrJKL previously approved these changes Sep 26, 2025

View reviewed changes

snomiao dismissed DrJKL’s stale review via cfde2f4 September 26, 2025 07:21

[chore] Merge main and keep npx -> pnpm exec/dlx conversions

24055a3

- Resolved merge conflicts by taking main branch changes - Reapplied npx -> pnpm exec conversions for installed deps - Removed .mcp.json as it was deleted in main

snomiao enabled auto-merge (squash) September 26, 2025 07:32

DrJKL approved these changes Sep 26, 2025

View reviewed changes

snomiao merged commit 49f373c into main Sep 26, 2025
21 checks passed

snomiao deleted the sno-pnpx branch September 26, 2025 17:06

[chore] Replace npx with pnpx across the codebase #5329

[chore] Replace npx with pnpx across the codebase #5329

Uh oh!

Conversation

snomiao commented Sep 4, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Plan

Uh oh!

github-actions bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

DrJKL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snomiao commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

DrJKL left a comment

Choose a reason for hiding this comment

Uh oh!

DrJKL Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

snomiao Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrJKL commented Sep 26, 2025

Uh oh!

snomiao commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

snomiao commented Sep 4, 2025 •

edited by sync-by-unito bot

Loading

github-actions bot commented Sep 4, 2025 •

edited

Loading

snomiao commented Sep 26, 2025 •

edited

Loading