Skip to content

Conversation

@webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Sep 4, 2025

Use --workspace-root flag to install at workspace level. The GH Action requires this due to pnpm workspace changes.

┆Issue is synchronized with this Notion page by Unito

Use --workspace-root flag to install at workspace level
@webfiltered webfiltered requested a review from a team as a code owner September 4, 2025 05:17
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 4, 2025
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/04/2025, 05:28:06 AM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

@webfiltered webfiltered requested a review from DrJKL September 4, 2025 05:18
@webfiltered
Copy link
Contributor Author

@DrJKL Sanity check, please~

... the action, not me.

@webfiltered webfiltered merged commit 9a9f8c7 into main Sep 4, 2025
22 checks passed
@webfiltered webfiltered deleted the electron-ci branch September 4, 2025 05:45
@DrJKL
Copy link
Contributor

DrJKL commented Sep 4, 2025

Yeah, we'll have to update it once we move the current app code down into an /apps, but for now targeting the root makes sense.

@webfiltered
Copy link
Contributor Author

Follow-up inbound. I just eyeballed the action; it'll throw if you try to run it.

@benceruleanlu benceruleanlu mentioned this pull request Sep 4, 2025
snomiao pushed a commit that referenced this pull request Sep 12, 2025
Use --workspace-root flag to install at workspace level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants