Skip to content

fix: Add hasConflict prop to PackEnableToggle component #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 1 commit into from
Sep 6, 2025
Merged

fix: Add hasConflict prop to PackEnableToggle component #5392

christian-byrne merged 1 commit into from
Sep 6, 2025

Conversation

@viva-jinyi
Copy link
Member

@viva-jinyi viva-jinyi commented Sep 6, 2025 •
edited by sync-by-unito bot
Loading

Summary

  • Added missing hasConflict prop to PackEnableToggle component in PackCardFooter.vue
  • This ensures the enable toggle button receives conflict state information consistently

Changes

  • Pass hasConflicts prop to PackEnableToggle component to maintain consistent conflict state handling

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

@viva-jinyi viva-jinyi requested a review from a team as a code owner September 6, 2025 11:29
@viva-jinyi viva-jinyi self-assigned this Sep 6, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 6, 2025
@github-actions
Copy link

github-actions bot commented Sep 6, 2025 •
edited
Loading

🎭 Playwright Test Results

✅ All tests passed across all browsers!

⏰ Completed at: 09/06/2025, 11:40:17 AM UTC

📊 Test Reports by Browser

🎉 Your tests are passing across all browsers!

@viva-jinyi viva-jinyi force-pushed the manager/fix/enable-conflict branch from b2e9447 to d2ecfb1 Compare September 6, 2025 11:30
@viva-jinyi viva-jinyi added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch area:manager 1.26 labels Sep 6, 2025
christian-byrne
christian-byrne approved these changes Sep 6, 2025
View reviewed changes
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christian-byrne christian-byrne merged commit 30d337c into main Sep 6, 2025
31 checks passed
@christian-byrne christian-byrne deleted the manager/fix/enable-conflict branch September 6, 2025 19:37
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch labels Sep 6, 2025
github-actions bot pushed a commit that referenced this pull request Sep 6, 2025
@viva-jinyi @github-actions
fix: packEnable button added hasConflict props (#5392)
7ffbfc1
@comfy-pr-bot comfy-pr-bot mentioned this pull request Sep 6, 2025
Merged
@comfy-pr-bot
Copy link
Member

comfy-pr-bot commented Sep 6, 2025

@viva-jinyi Successfully backported to #5402

christian-byrne pushed a commit that referenced this pull request Sep 6, 2025
@comfy-pr-bot @viva-jinyi
fix: packEnable button added hasConflict props (#5392) (#5402)
2bb158c 
Co-authored-by: Jin Yi <[email protected]>
This was referenced Sep 7, 2025
Merged
Merged
snomiao pushed a commit that referenced this pull request Sep 12, 2025
@viva-jinyi @snomiao
fix: packEnable button added hasConflict props (#5392)
415b6bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

@viva-jinyi viva-jinyi

Labels

1.26 area:manager needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@viva-jinyi @comfy-pr-bot @christian-byrne