Skip to content

Remove accidental onMouseDown handler #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 3 commits into from
Sep 7, 2025
Merged

Remove accidental onMouseDown handler #5405

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa36845
Remove accidental onMouseDown handler
AustinMroz Sep 6, 2025
f809ff5
Fix test snapshot
AustinMroz Sep 6, 2025
d2bd5fd
Add test that onMouseDown isn't overwritten
AustinMroz Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test that onMouseDown isn't overwritten
  • Loading branch information
@AustinMroz
AustinMroz committed Sep 7, 2025
commit d2bd5fd33141515f0e04ea3586bde5e4d0e18a2a
5 changes: 5 additions & 0 deletions tests-ui/tests/litegraph/core/LGraphNode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,5 +621,10 @@ describe('LGraphNode', () => {
expect(node.getInputSlotPos(inputSlot)).toEqual([expectedX, expectedY])
delete (node.constructor as any).slot_start_y
})
test('should not overwrite onMouseDown prototype', () => {
expect(Object.prototype.hasOwnProperty.call(node, 'onMouseDown')).toEqual(
false
)
})
})
})
Loading