Skip to content

feat: add test count display to Playwright PR comments #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 14 commits into from
Sep 13, 2025
Merged

feat: add test count display to Playwright PR comments #5458

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5ae6efd
feat: add test count display to Playwright PR comments
snomiao Sep 9, 2025
939c0ba
feat: include skipped test count in per-browser display
snomiao Sep 9, 2025
c7668ea
fix: improve test count extraction reliability in CI
snomiao Sep 9, 2025
e8e3003
fix: generate JSON reports alongside HTML for test count extraction
snomiao Sep 9, 2025
605d7cc
fix: correct JSON reporter syntax for Playwright tests
snomiao Sep 10, 2025
dd60e91
Revert "fix: correct JSON reporter syntax for Playwright tests"
snomiao Sep 10, 2025
0d74cfa
fix: use correct Playwright reporter syntax with comma-separated list
snomiao Sep 10, 2025
fcc8d88
fix: improve test count extraction reliability in CI
snomiao Sep 10, 2025
bdf5c73
Merge branch 'main' into sno-playwright-comment-counts
snomiao Sep 10, 2025
8b60af1
Update scripts/cicd/pr-playwright-deploy-and-comment.sh
snomiao Sep 10, 2025
d6174b7
refactor: convert extraction script to TypeScript and use tsx
snomiao Sep 10, 2025
ed8d450
chore(pr-playwright-deploy-and-comment.sh): move tsx installation che…
snomiao Sep 10, 2025
4028b25
[auto-fix] Apply ESLint and Prettier fixes
actions-user Sep 10, 2025
85a9437
Merge branch 'main' into sno-playwright-comment-counts
snomiao Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use correct Playwright reporter syntax with comma-separated list 
- Use --reporter=html,json syntax (comma-separated, not space)
- Move test-results.json to playwright-report/report.json after generation
- Remove incorrect PLAYWRIGHT_JSON_OUTPUT_NAME env variable
- Add || true to prevent failure if JSON file doesn't exist

The JSON reporter outputs to test-results.json by default when using
the comma-separated reporter list syntax.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
@snomiao @claude
snomiao and claude committed Sep 10, 2025
commit 0d74cfafa85a95561e2afa26f1536fb7deee92cd
15 changes: 7 additions & 8 deletions .github/workflows/test-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,11 @@ jobs:

- name: Run Playwright tests (${{ matrix.browser }})
id: playwright
run: npx playwright test --project=${{ matrix.browser }} --reporter=html --reporter=json
run: |
npx playwright test --project=${{ matrix.browser }} --reporter=html,json
# JSON report is saved to test-results.json by default, move it to the report directory
[ -f "test-results.json" ] && mv test-results.json playwright-report/report.json || true
working-directory: ComfyUI_frontend
env:
PLAYWRIGHT_JSON_OUTPUT_NAME: playwright-report/report.json

- uses: actions/upload-artifact@v4
if: always()
Expand Down Expand Up @@ -278,12 +279,10 @@ jobs:

- name: Merge into HTML Report
run: |
npx playwright merge-reports --reporter html --reporter json ./all-blob-reports
# Move JSON report to the HTML report directory for easier access
[ -f "report.json" ] && mv report.json playwright-report/report.json
npx playwright merge-reports --reporter=html,json ./all-blob-reports
# JSON report is saved to test-results.json by default, move it to the report directory
[ -f "test-results.json" ] && mv test-results.json playwright-report/report.json || true
working-directory: ComfyUI_frontend
env:
PLAYWRIGHT_JSON_OUTPUT_NAME: report.json

- name: Upload HTML report
uses: actions/upload-artifact@v4
Expand Down
Loading