fix: update Claude PR Review workflow to use correct action parameters

[snomiao]

Problem

The claude-review label workflow wasn't working in PR #5458 because the workflow file was using deprecated input parameters from v0.x of the anthropics/claude-code-action.

Root Cause

According to the migration guide, the action underwent significant changes from v0.x to v1.0. Our workflow was still using the old v0.x parameters:

• direct_prompt instead of prompt
• max_turns as a direct input instead of through claude_args
• timeout_minutes as a direct input (should be set at job level or via claude_args)
• allowed_tools instead of using claude_args or additional_permissions

These deprecated parameters are not recognized by v1.0+, causing the action to fail silently with a warning about unexpected inputs.

Solution

1. Updated parameters following the v0.x to v1.0 migration guide:

   • Changed direct_prompt → prompt
   • Moved max_turns and timeout to claude_args parameter as --max-turns 256 --timeout 30
   • Changed allowed_tools → additional_permissions

2. Pinned version to v1.0.6 instead of using @main to prevent future breakage from unexpected updates

Testing

This should be tested by:

1. Merging this PR
2. Adding the claude-review label to a test PR
3. Verifying that Claude actually reviews the PR and posts comments

References

• Claude Code Action Migration Guide (v0.x to v1.0)
• Original issue reported in PR feat: add test count display to Playwright PR comments #5458

🤖 Generated with Claude Code

[github-actions]

🎭 Playwright Test Results

✅ Tests completed successfully!

⏰ Completed at: 09/10/2025, 06:16:42 AM UTC

📊 Test Reports by Browser

• ✅ chromium: View Report
• ✅ chromium-2x: View Report
• ✅ chromium-0.5x: View Report
• ✅ mobile-chrome: View Report

---

🎉 Click on the links above to view detailed test results for each browser configuration.

[snomiao]

Review: Migration to claude-code-action v1.0

I've reviewed this PR against the official migration guide and found a few issues:

✅ Correctly Fixed

1. direct_prompt → prompt - Correctly migrated ✓
2. max_turns → claude_args - Correctly moved to --max-turns 256 ✓
3. Version pinning - Good practice to pin to v1.0.6 ✓

⚠️ Issues to Address

1. allowed_tools parameter: According to the migration guide, this should be --allowedTools in claude_args, not additional_permissions. The correct migration would be:

   claude_args: "--max-turns 256 --timeout 30 --allowedTools 'Bash(git:*),Bash(gh api:*),Bash(gh pr:*),Bash(gh repo:*),Bash(jq:*),Bash(echo:*),Read,Write,Edit,Glob,Grep,WebFetch'"

2. timeout parameter: The migration guide states that timeout should be set at the job level as timeout-minutes, not in claude_args. The --timeout flag in claude_args might not work as expected.

📝 Recommended Changes

claude-review:
  needs: wait-for-ci
  if: needs.wait-for-ci.outputs.should-proceed == 'true'
  runs-on: ubuntu-latest
  timeout-minutes: 30  # Add this at job level
  steps:
    # ... other steps ...
    
    - name: Run Claude PR Review
      uses: anthropics/[email protected]
      with:
        label_trigger: "claude-review"
        prompt: |
          Read the file .claude/commands/comprehensive-pr-review.md and follow ALL the instructions exactly. 
          
          CRITICAL: You must post individual inline comments using the gh api commands shown in the file. 
          DO NOT create a summary comment. 
          Each issue must be posted as a separate inline comment on the specific line of code.
        anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
        claude_args: "--max-turns 256 --allowedTools 'Bash(git:*),Bash(gh api:*),Bash(gh pr:*),Bash(gh repo:*),Bash(jq:*),Bash(echo:*),Read,Write,Edit,Glob,Grep,WebFetch'"

The additional_permissions parameter doesn't appear in the migration guide or the valid inputs list, so it might be ignored or cause issues.

[snomiao]

✅ Update: All Issues Fixed

The review feedback has been implemented in commit 5f6df80:

Applied Fixes

1. ✅ Moved timeout to job level: Added timeout-minutes: 30 at the job level instead of in claude_args
2. ✅ Fixed allowed tools parameter: Changed to --allowedTools in claude_args with proper format
3. ✅ Removed invalid parameter: Removed additional_permissions which isn't a valid input

Current Implementation (Correct)

claude-review:
  needs: wait-for-ci
  if: needs.wait-for-ci.outputs.should-proceed == 'true'
  runs-on: ubuntu-latest
  timeout-minutes: 30  # ✅ At job level as per migration guide
  steps:
    # ... other steps ...
    
    - name: Run Claude PR Review
      uses: anthropics/[email protected]  # ✅ Pinned version
      with:
        label_trigger: "claude-review"
        prompt: |  # ✅ Correct parameter name (was direct_prompt)
          Read the file .claude/commands/comprehensive-pr-review.md and follow ALL the instructions exactly. 
          
          CRITICAL: You must post individual inline comments using the gh api commands shown in the file. 
          DO NOT create a summary comment. 
          Each issue must be posted as a separate inline comment on the specific line of code.
        anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
        claude_args: "--max-turns 256 --allowedTools 'Bash(git:*),Bash(gh api:*),Bash(gh pr:*),Bash(gh repo:*),Bash(jq:*),Bash(echo:*),Read,Write,Edit,Glob,Grep,WebFetch'"  # ✅ Correct format per migration guide

The workflow now fully complies with the v0.x to v1.0 migration guide and should work correctly when the claude-review label is applied.

[christian-byrne]

TY!