Skip to content

fix(collect-i18n-node-defs): refactor to run ComfyNodeDefImpl only in browser context #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 7 commits into from
Sep 26, 2025
Merged

fix(collect-i18n-node-defs): refactor to run ComfyNodeDefImpl only in browser context #5775

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c733a27
Enhance locale update workflow to include 'sno-fix-locale' branch det…
snomiao Sep 26, 2025
3d88e80
Refactor: Simplify node definitions collection in collect-i18n-node-d…
snomiao Sep 26, 2025
e810102
Update locales [skip ci]
invalid-email-address Sep 26, 2025
84b5b45
Revert "Enhance locale update workflow to include 'sno-fix-locale' br…
snomiao Sep 26, 2025
6c5cb8b
Merge branch 'main' into sno-fix-locale
snomiao Sep 26, 2025
3bc739a
fix: use ComfyNodeDef type for node definitions filtering and mapping
snomiao Sep 26, 2025
0ad76b9
Revert "Update locales [skip ci]"
snomiao Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use ComfyNodeDef type for node definitions filtering and mapping
  • Loading branch information
@snomiao
snomiao committed Sep 26, 2025
commit 3bc739a8daeb30e32bf640088e07a00f1174deea
6 changes: 4 additions & 2 deletions scripts/collect-i18n-node-defs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import * as fs from 'fs'

import type { ComfyNodeDef } from '@/schemas/nodeDefSchema'

import { comfyPageFixture as test } from '../browser_tests/fixtures/ComfyPage'
import type { ComfyNodeDefImpl } from '../src/stores/nodeDefStore'
import { normalizeI18nKey } from '../src/utils/formatUtil'
Expand Down Expand Up @@ -36,8 +38,8 @@ test('collect-i18n-node-defs', async ({ comfyPage }) => {
return (
Object.values(rawNodeDefs)
// Ignore DevTools nodes (used for internal testing)
.filter((def: any) => !def.name.startsWith('DevTools'))
.map((def: any) => new ComfyNodeDefImpl(def))
.filter((def: ComfyNodeDef) => !def.name.startsWith('DevTools'))
.map((def: ComfyNodeDef) => new ComfyNodeDefImpl(def))
)
}
)
Expand Down