Skip to content

style: update ui and design of system notification components (what's new, new release notification, help center) #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 23 commits into from
Dec 9, 2025
Merged

style: update ui and design of system notification components (what's new, new release notification, help center) #6300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e39c8ce
update notifications components designs
christian-byrne Oct 26, 2025
7430772
fix stylelint issues
christian-byrne Oct 26, 2025
593edd5
fix test locator
christian-byrne Oct 26, 2025
a24643a
update release notification components with semantic design tokens
christian-byrne Oct 29, 2025
40ba53d
fix notification component tests and remove temporary mock data
christian-byrne Nov 6, 2025
f155a18
implement new designs
christian-byrne Nov 7, 2025
87d434c
fix test
christian-byrne Nov 7, 2025
e7c9cdf
update style
christian-byrne Nov 13, 2025
e563ca5
use correct tokens
christian-byrne Nov 13, 2025
4b3ccd9
remove border radius token
christian-byrne Nov 14, 2025
c370386
[feat] Implement proper design tokens and Storybook stories for relea…
christian-byrne Nov 27, 2025
5c514eb
add i18n
christian-byrne Nov 27, 2025
1faf41b
[fix] Fix notification component tests and improve empty content hand…
christian-byrne Nov 30, 2025
57bf2ae
[security] Fix XSS vulnerability in notification components
christian-byrne Nov 30, 2025
6f3abc7
[fix] Address nitpick comments
christian-byrne Dec 4, 2025
062b1a7
Remove merge marker
DrJKL Dec 4, 2025
b1ab138
fix: remove inappropriate update button from WhatsNewPopup and add sc…
christian-byrne Dec 6, 2025
468335c
refactor: remove inappropriate image stories from toast component
christian-byrne Dec 9, 2025
ee89a3a
[fix] resolve merge conflict markers in main.json
christian-byrne Dec 9, 2025
a7d949a
[fix] remove TypeScript any casts and improve type safety in tests
christian-byrne Dec 9, 2025
892d785
[fix] correct HTML rel attribute, use semantic CSS token, prevent tes…
christian-byrne Dec 9, 2025
0724df8
[fix] use i18n for hardcoded strings, fix Storybook vitest mock, clea…
christian-byrne Dec 9, 2025
b83b4e5
[fix] add recentRelease mock to Storybook for proper component rendering
christian-byrne Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions browser_tests/tests/releaseNotifications.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section shows the release
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Should show the release version
Expand Down Expand Up @@ -79,7 +79,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section shows no releases
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Should show "No recent releases" message
Expand Down Expand Up @@ -125,7 +125,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Should show no releases due to error
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(
whatsNewSection.locator('text=No recent releases')
).toBeVisible()
Expand Down Expand Up @@ -175,7 +175,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section is hidden
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).not.toBeVisible()

// Should not show any popups or toasts
Expand Down Expand Up @@ -260,7 +260,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Verify "What's New?" section is visible
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Should show the release
Expand Down Expand Up @@ -308,7 +308,7 @@ test.describe('Release Notifications', () => {
await helpCenterButton.click()

// Verify "What's New?" section is visible
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).toBeVisible()

// Close help center
Expand Down Expand Up @@ -359,7 +359,7 @@ test.describe('Release Notifications', () => {
await expect(helpMenu).toBeVisible()

// Section should be hidden regardless of empty releases
const whatsNewSection = comfyPage.page.locator('.whats-new-section')
const whatsNewSection = comfyPage.page.getByTestId('whats-new-section')
await expect(whatsNewSection).not.toBeVisible()
})
})
10 changes: 10 additions & 0 deletions packages/design-system/src/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@
--color-danger-100: #c02323;
--color-danger-200: #d62952;



--color-coral-red-600: #973a40;
--color-coral-red-500: #c53f49;
--color-coral-red-400: #dd424e;
Expand Down Expand Up @@ -183,9 +185,13 @@
--interface-menu-component-surface-hovered: var(--color-smoke-200);
--interface-menu-component-surface-selected: var(--color-smoke-400);
--interface-menu-keybind-surface-default: var(--color-smoke-500);
--interface-menu-surface: var(--color-white);
--interface-menu-stroke: var(--color-smoke-600);
--interface-panel-surface: var(--color-white);
--interface-stroke: var(--color-smoke-300);



--nav-background: var(--color-white);

--node-border: var(--color-smoke-300);
Expand Down Expand Up @@ -301,6 +307,8 @@
--interface-menu-component-surface-hovered: var(--color-charcoal-400);
--interface-menu-component-surface-selected: var(--color-charcoal-300);
--interface-menu-keybind-surface-default: var(--color-charcoal-200);
--interface-menu-surface: var(--color-charcoal-800);
--interface-menu-stroke: var(--color-ash-800);
--interface-panel-surface: var(--color-charcoal-800);
--interface-stroke: var(--color-charcoal-400);

Expand Down Expand Up @@ -416,6 +424,8 @@
--color-interface-menu-keybind-surface-default: var(
--interface-menu-keybind-surface-default
);
--color-interface-menu-surface: var(--interface-menu-surface);
--color-interface-menu-stroke: var(--interface-menu-stroke);
--color-interface-panel-surface: var(--interface-panel-surface);
--color-interface-panel-hover-surface: var(--interface-panel-hover-surface);
--color-interface-panel-selected-surface: var(
Expand Down
Loading