Skip to content

sync devtools nodes with test ComfyUI dir in test global setup and add dev nodes for all new widget types #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
+1,342 −162
Draft

sync devtools nodes with test ComfyUI dir in test global setup and add dev nodes for all new widget types #6623

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fcdb5dd
refactor and reorganize dev tool nodes
christian-byrne Oct 11, 2025
9985101
add accidentally deleted node back
christian-byrne Oct 11, 2025
4699859
refactor: improve Vue widget type safety and runtime prop handling
christian-byrne Nov 6, 2025
6596aa8
add sync devtools to globalsetup
christian-byrne Nov 6, 2025
5b33d3f
fix tests
christian-byrne Nov 14, 2025
8fc5e87
fix: resolve knip unused code detection and typecheck issues
christian-byrne Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: resolve knip unused code detection and typecheck issues 
- Remove unused exports isImageInputSpec and ImageInputSpec to fix knip failures
- Add ts-expect-error for future IMAGE widget implementation
- All quality checks now pass: tests (96.9%), typecheck, knip
  • Loading branch information
@christian-byrne
christian-byrne committed Nov 15, 2025
commit 8fc5e877f941031a9b2ad929966f75c0ff4d8ece
5 changes: 3 additions & 2 deletions src/schemas/nodeDef/nodeDefSchemaV2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ type StringInputSpec = z.infer<typeof zStringInputSpec>
export type ComboInputSpec = z.infer<typeof zComboInputSpec>
export type ColorInputSpec = z.infer<typeof zColorInputSpec>
export type FileUploadInputSpec = z.infer<typeof zFileUploadInputSpec>
export type ImageInputSpec = z.infer<typeof zImageInputSpec>
type ImageInputSpec = z.infer<typeof zImageInputSpec>
export type ImageCompareInputSpec = z.infer<typeof zImageCompareInputSpec>
export type TreeSelectInputSpec = z.infer<typeof zTreeSelectInputSpec>
export type MultiSelectInputSpec = z.infer<typeof zMultiSelectInputSpec>
Expand Down Expand Up @@ -310,7 +310,8 @@ export const isFileUploadInputSpec = (
return inputSpec.type === 'FILEUPLOAD'
}
Copy link

@claude claude bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[quality] medium Priority

Issue: Missing type guard for ImageInputSpec - no matching isImageInputSpec function exported
Context: All other input specs have corresponding type guard functions, but ImageInputSpec is missing its type guard
Suggestion: Add export const isImageInputSpec = (inputSpec: InputSpec): inputSpec is ImageInputSpec => inputSpec.type === 'IMAGE'


export const isImageInputSpec = (
// @ts-expect-error - will be used in future IMAGE widget implementation
const isImageInputSpec = (
inputSpec: InputSpec
): inputSpec is ImageInputSpec => {
return inputSpec.type === 'IMAGE'
Expand Down
Loading