Fix: Selected assets count not updating in Imported tab #6842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
📝 WalkthroughWalkthroughThe Changes
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/23/2025, 08:28:42 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
viva-jinyi
changed the title
🎭 Playwright Test Results⏰ Completed at: 11/23/2025, 08:39:21 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 940 kB (baseline 940 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 141 kB (baseline 141 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.7 MB (baseline 5.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
DrJKL
approved these changes
Nov 23, 2025
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
## Summary - Fix bug where the "Selected assets count" displayed as 0 in the Imported tab when selecting assets ## Root Cause The `getOutputCount` function was returning `0` when `user_metadata.outputCount` was not present. - **Generated tab**: Works correctly because `outputCount` metadata is set during generation - **Imported tab**: `outputCount` metadata is never set, so it always returns `0` → selected count shows as 0 ## Solution Changed the default return value from `0` to `1` when `outputCount` metadata is not present, ensuring every asset counts as at least 1. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
## Summary - Fix bug where the "Selected assets count" displayed as 0 in the Imported tab when selecting assets ## Root Cause The `getOutputCount` function was returning `0` when `user_metadata.outputCount` was not present. - **Generated tab**: Works correctly because `outputCount` metadata is set during generation - **Imported tab**: `outputCount` metadata is never set, so it always returns `0` → selected count shows as 0 ## Solution Changed the default return value from `0` to `1` when `outputCount` metadata is not present, ensuring every asset counts as at least 1. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Member
|
@viva-jinyi Backport branch created but PR creation failed for |
Member
|
@viva-jinyi Successfully backported to #6873 |
github-actions
bot
removed
the
needs-backport
christian-byrne
pushed a commit
that referenced
this pull request
Nov 23, 2025
…rted tab (#6873) Backport of #6842 to `cloud/1.32` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6873-backport-cloud-1-32-Fix-Selected-assets-count-not-updating-in-Imported-tab-2b46d73d365081a0992bed6de971d81e) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <[email protected]>
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
## Summary - Fix bug where the "Selected assets count" displayed as 0 in the Imported tab when selecting assets ## Root Cause The `getOutputCount` function was returning `0` when `user_metadata.outputCount` was not present. - **Generated tab**: Works correctly because `outputCount` metadata is set during generation - **Imported tab**: `outputCount` metadata is never set, so it always returns `0` → selected count shows as 0 ## Solution Changed the default return value from `0` to `1` when `outputCount` metadata is not present, ensuring every asset counts as at least 1. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Member
|
@viva-jinyi Successfully backported to #6931 |
github-actions
bot
removed
the
needs-backport
christian-byrne
pushed a commit
that referenced
this pull request
Nov 25, 2025
…ted tab (#6931) Backport of #6842 to `core/1.32` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6931-backport-core-1-32-Fix-Selected-assets-count-not-updating-in-Imported-tab-2b66d73d365081edb16ce02c2b55ada0) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The
getOutputCountfunction was returning0whenuser_metadata.outputCountwas not present.outputCountmetadata is set during generationoutputCountmetadata is never set, so it always returns0→ selected count shows as 0Solution
Changed the default return value from
0to1whenoutputCountmetadata is not present, ensuring every asset counts as at least 1.🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito