Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix: Cloud notification badge reactivity and modal timing
- Fix badge not appearing by accessing settingStore.settingValues directly for proper reactivity
- Increase modal delay to 2s to ensure it appears after missing models dialog
- Move setting update inside setTimeout to only save when modal actually shows

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
deepme987 and claude committed Nov 23, 2025
commit 7bba8f09f6b56481bb55f98d71eaae577f578e33
24 changes: 16 additions & 8 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,23 @@ onMounted(async () => {
void conflictDetection.initializeConflictDetection()

// Show cloud notification for macOS desktop users (one-time)
const isMacOS = navigator.platform.toLowerCase().includes('mac')
const settingStore = useSettingStore()
const hasShownNotification = settingStore.get(
'Comfy.Desktop.CloudNotificationShown'
)
// Delayed to ensure it appears after workflow loading (missing models dialog, etc.)
if (isElectron()) {
const isMacOS = navigator.platform.toLowerCase().includes('mac')
if (isMacOS) {
const settingStore = useSettingStore()
const hasShownNotification = settingStore.get(
'Comfy.Desktop.CloudNotificationShown'
)

if (isElectron() && isMacOS && !hasShownNotification) {
dialogService.showCloudNotification()
await settingStore.set('Comfy.Desktop.CloudNotificationShown', true)
if (!hasShownNotification) {
// Delay to show after initial workflow loading completes
setTimeout(async () => {
dialogService.showCloudNotification()
await settingStore.set('Comfy.Desktop.CloudNotificationShown', true)
}, 2000)
}
}
}
})
</script>
6 changes: 4 additions & 2 deletions src/components/topbar/TopbarBadges.vue
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ const dialogService = useDialogService()

const isMacOS = computed(() => navigator.platform.toLowerCase().includes('mac'))

const hasShownNotification = computed(() =>
settingStore.get('Comfy.Desktop.CloudNotificationShown')
// Access the reactive store state directly for proper reactivity
const hasShownNotification = computed(
() =>
settingStore.settingValues['Comfy.Desktop.CloudNotificationShown'] ?? false
)

const shouldShowCloudBadge = computed(
Expand Down
Loading